linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Palmer <daniel@0x0f.com>
To: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
	robh@kernel.org, romain.perier@gmail.com,
	Daniel Palmer <daniel@0x0f.com>
Subject: [PATCH 03/10] gpio: msc313: Code clean ups
Date: Sat, 17 Jul 2021 13:56:20 +0900	[thread overview]
Message-ID: <20210717045627.1739959-4-daniel@0x0f.com> (raw)
In-Reply-To: <20210717045627.1739959-1-daniel@0x0f.com>

- Remove the unneeded assignment of ret before returning it.
- Remove an unneeded blank line

Signed-off-by: Daniel Palmer <daniel@0x0f.com>
---
 drivers/gpio/gpio-msc313.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpio/gpio-msc313.c b/drivers/gpio/gpio-msc313.c
index da31a5ff7a2b..a894bafbd4c3 100644
--- a/drivers/gpio/gpio-msc313.c
+++ b/drivers/gpio/gpio-msc313.c
@@ -344,7 +344,6 @@ static int msc313_gpio_probe(struct platform_device *pdev)
 	struct irq_domain *parent_domain;
 	struct device_node *parent_node;
 	struct device *dev = &pdev->dev;
-	int ret;
 
 	match_data = of_device_get_match_data(dev);
 	if (!match_data)
@@ -399,8 +398,7 @@ static int msc313_gpio_probe(struct platform_device *pdev)
 	gpioirqchip->handler = handle_bad_irq;
 	gpioirqchip->default_type = IRQ_TYPE_NONE;
 
-	ret = devm_gpiochip_add_data(dev, gpiochip, gpio);
-	return ret;
+	return devm_gpiochip_add_data(dev, gpiochip, gpio);
 }
 
 static int msc313_gpio_remove(struct platform_device *pdev)
@@ -456,5 +454,4 @@ static struct platform_driver msc313_gpio_driver = {
 	.probe = msc313_gpio_probe,
 	.remove = msc313_gpio_remove,
 };
-
 builtin_platform_driver(msc313_gpio_driver);
-- 
2.32.0


  parent reply	other threads:[~2021-07-17  4:57 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-17  4:56 [PATCH 00/10] gpio: msc313: Add gpio support for ssd20xd Daniel Palmer
2021-07-17  4:56 ` [PATCH 01/10] dt-bindings: gpio: msc313: Add compatible " Daniel Palmer
2021-07-22  3:08   ` Rob Herring
2021-07-30 10:09   ` Linus Walleij
2021-07-17  4:56 ` [PATCH 02/10] dt-bindings: gpio: msc313: Add offsets " Daniel Palmer
2021-07-22  3:08   ` Rob Herring
2021-07-30 10:09   ` Linus Walleij
2021-07-17  4:56 ` Daniel Palmer [this message]
2021-07-30 10:10   ` [PATCH 03/10] gpio: msc313: Code clean ups Linus Walleij
2021-07-17  4:56 ` [PATCH 04/10] gpio: msc313: Add support for SSD201 and SSD202D Daniel Palmer
2021-07-30 10:10   ` Linus Walleij
2021-07-17  4:56 ` [PATCH 05/10] ARM: dts: mstar: Set gpio compatible for ssd20xd Daniel Palmer
2021-07-30 10:11   ` Linus Walleij
2021-08-03 10:13     ` Romain Perier
2021-07-17  4:56 ` [PATCH 06/10] ARM: dts: mstar: unitv2: Wire up LEDs Daniel Palmer
2021-07-17  4:56 ` [PATCH 07/10] ARM: dts: mstar: unitv2: Add core regulator Daniel Palmer
2021-07-17  4:56 ` [PATCH 08/10] ARM: dts: mstar: unitv2: Add io regulator Daniel Palmer
2021-07-17  4:56 ` [PATCH 09/10] ARM: dts: mstar: unitv2: Add DRAM regulator Daniel Palmer
2021-07-17  4:56 ` [PATCH 10/10] ARM: dts: mstar: unitv2: Add wifi switch Daniel Palmer
2021-07-30 10:12 ` [PATCH 00/10] gpio: msc313: Add gpio support for ssd20xd Linus Walleij
2021-07-30 10:19   ` Daniel Palmer
2021-08-25 11:50   ` Daniel Palmer
2021-09-22 10:20     ` Bartosz Golaszewski
2021-09-22 10:46       ` Daniel Palmer
2021-09-22 10:51       ` Andy Shevchenko
2021-09-22 12:50         ` Bartosz Golaszewski
2021-09-22 12:56           ` Andy Shevchenko
2021-09-22 14:52           ` Daniel Palmer
2021-09-22 23:50           ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210717045627.1739959-4-daniel@0x0f.com \
    --to=daniel@0x0f.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=romain.perier@gmail.com \
    --subject='Re: [PATCH 03/10] gpio: msc313: Code clean ups' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).