From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BE24C636C9 for ; Mon, 19 Jul 2021 09:08:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FD396100C for ; Mon, 19 Jul 2021 09:08:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235875AbhGSI1T (ORCPT ); Mon, 19 Jul 2021 04:27:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:42582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235844AbhGSI1S (ORCPT ); Mon, 19 Jul 2021 04:27:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BE1BA600CD; Mon, 19 Jul 2021 09:07:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626685679; bh=od5XSDQTfWU6h3EBK31swNvCr2oAj09MRWLUd2Bmnk8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jtQXNI4SmLk8EtT5ECK7dKulrmM27pE6h63WGyxaR8Zhvmv3AptHX4KRl98JRmYhe HXR3DKCvblTMrhg+ZmnL+GmB2q3l9rrTWyjz4E5Cm5HZngF7KQJp1EiYwTguPwAB/j koLO92gxFUnUzu26HblHWuQOSG5oQu2t0LrrTS5NLTLZuIWZel2X9pOLkH57LHxGRx LWv4Yy3Ke3k/6jk2tuUbzqlvudtBqSMgd6W0wUZh3EK23eC3jmAyV2O6ZXDA9eLL6F MJrVkaLMT98XhmlWbWORhGQxvay7vs+ybFoyINZRkQ14E6eneZ/X/1olMf+HUdCNTE LtJqIr02RyIHw== Date: Mon, 19 Jul 2021 10:07:54 +0100 From: Will Deacon To: Xiyu Yang Cc: Joerg Roedel , Suravee Suthikulpanit , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, yuanxzhang@fudan.edu.cn, Xin Tan Subject: Re: [PATCH] iommu/amd: Convert from atomic_t to refcount_t on device_state->count Message-ID: <20210719090754.GB6221@willie-the-truck> References: <1626674437-56007-1-git-send-email-xiyuyang19@fudan.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1626674437-56007-1-git-send-email-xiyuyang19@fudan.edu.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 19, 2021 at 02:00:37PM +0800, Xiyu Yang wrote: > refcount_t type and corresponding API can protect refcounters from > accidental underflow and overflow and further use-after-free situations. > > Signed-off-by: Xiyu Yang > Signed-off-by: Xin Tan > --- > drivers/iommu/amd/iommu_v2.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) Can pasid_state::count be converted similarly? Will