From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: James Clark <james.clark@arm.com>
Cc: acme@kernel.org, coresight@lists.linaro.org, leo.yan@linaro.org,
al.grant@arm.com, branislav.rankov@arm.com,
suzuki.poulose@arm.com, anshuman.khandual@arm.com,
Mike Leach <mike.leach@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] perf cs-etm: Split setup and timestamp search functions
Date: Mon, 19 Jul 2021 13:38:21 -0600 [thread overview]
Message-ID: <20210719193821.GC2255168@p14s> (raw)
In-Reply-To: <20210713154008.29656-3-james.clark@arm.com>
On Tue, Jul 13, 2021 at 04:40:04PM +0100, James Clark wrote:
> This refactoring has some benefits:
> * Decoding is done to find the timestamp. If we want to print errors
> when maps aren't available, then doing it from cs_etm__setup_queue()
> may cause warnings to be printed.
> * The cs_etm__setup_queue() flow is shared between timed and timeless
> modes, so it needs to be guarded by an if statement which can now
> be removed.
> * Allows moving the setup queues function earlier.
> * If data was piped in, then not all queues would be filled so it
> wouldn't have worked properly anyway. Now it waits for flush so
> data in all queues will be available.
>
> The motivation for this is to decouple setup functions with ones that
> involve decoding. That way we can move the setup function earlier when
> the formatted/unformatted trace information is available.
>
> Signed-off-by: James Clark <james.clark@arm.com>
> ---
> tools/perf/util/cs-etm.c | 41 ++++++++++++++++++++++++++++------------
> 1 file changed, 29 insertions(+), 12 deletions(-)
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>
> diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
> index 4c69ef391f60..426e99c07ca9 100644
> --- a/tools/perf/util/cs-etm.c
> +++ b/tools/perf/util/cs-etm.c
> @@ -809,29 +809,32 @@ static int cs_etm__setup_queue(struct cs_etm_auxtrace *etm,
> struct auxtrace_queue *queue,
> unsigned int queue_nr)
> {
> - int ret = 0;
> - unsigned int cs_queue_nr;
> - u8 trace_chan_id;
> - u64 cs_timestamp;
> struct cs_etm_queue *etmq = queue->priv;
>
> if (list_empty(&queue->head) || etmq)
> - goto out;
> + return 0;
>
> etmq = cs_etm__alloc_queue(etm);
>
> - if (!etmq) {
> - ret = -ENOMEM;
> - goto out;
> - }
> + if (!etmq)
> + return -ENOMEM;
>
> queue->priv = etmq;
> etmq->etm = etm;
> etmq->queue_nr = queue_nr;
> etmq->offset = 0;
>
> - if (etm->timeless_decoding)
> - goto out;
> + return 0;
> +}
> +
> +static int cs_etm__queue_first_cs_timestamp(struct cs_etm_auxtrace *etm,
> + struct cs_etm_queue *etmq,
> + unsigned int queue_nr)
> +{
> + int ret = 0;
> + unsigned int cs_queue_nr;
> + u8 trace_chan_id;
> + u64 cs_timestamp;
>
> /*
> * We are under a CPU-wide trace scenario. As such we need to know
> @@ -2218,13 +2221,27 @@ static int cs_etm__process_timeless_queues(struct cs_etm_auxtrace *etm,
> static int cs_etm__process_queues(struct cs_etm_auxtrace *etm)
> {
> int ret = 0;
> - unsigned int cs_queue_nr, queue_nr;
> + unsigned int cs_queue_nr, queue_nr, i;
> u8 trace_chan_id;
> u64 cs_timestamp;
> struct auxtrace_queue *queue;
> struct cs_etm_queue *etmq;
> struct cs_etm_traceid_queue *tidq;
>
> + /*
> + * Pre-populate the heap with one entry from each queue so that we can
> + * start processing in time order across all queues.
> + */
> + for (i = 0; i < etm->queues.nr_queues; i++) {
> + etmq = etm->queues.queue_array[i].priv;
> + if (!etmq)
> + continue;
> +
> + ret = cs_etm__queue_first_cs_timestamp(etm, etmq, i);
> + if (ret)
> + return ret;
> + }
> +
> while (1) {
> if (!etm->heap.heap_cnt)
> goto out;
> --
> 2.28.0
>
next prev parent reply other threads:[~2021-07-19 20:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 15:40 [PATCH 0/6] perf cs-etm: Support TRBE (unformatted decoding) James Clark
2021-07-13 15:40 ` [PATCH 1/6] perf cs-etm: Refactor initialisation of kernel start address James Clark
2021-07-19 19:37 ` Mathieu Poirier
2021-07-13 15:40 ` [PATCH 2/6] perf cs-etm: Split setup and timestamp search functions James Clark
2021-07-19 19:38 ` Mathieu Poirier [this message]
2021-07-13 15:40 ` [PATCH 3/6] perf cs-etm: Only setup queues when they are modified James Clark
2021-07-19 19:38 ` Mathieu Poirier
2021-07-13 15:40 ` [PATCH 4/6] perf cs-etm: Suppress printing when resetting decoder James Clark
2021-07-19 19:39 ` Mathieu Poirier
2021-07-13 15:40 ` [PATCH 5/6] perf cs-etm: Use existing decoder instead of resetting it James Clark
2021-07-19 19:39 ` Mathieu Poirier
2021-07-13 15:40 ` [PATCH 6/6] perf cs-etm: Pass unformatted flag to decoder James Clark
2021-07-19 19:40 ` Mathieu Poirier
2021-07-20 15:45 ` Mathieu Poirier
2021-07-21 8:35 ` James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210719193821.GC2255168@p14s \
--to=mathieu.poirier@linaro.org \
--cc=acme@kernel.org \
--cc=al.grant@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=branislav.rankov@arm.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=namhyung@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).