From: Nishanth Menon <nm@ti.com>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: <kristo@kernel.org>,
Device Tree Mailing List <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] arm64: dts: ti: k3-am642-sk: Add ecap0 node
Date: Tue, 20 Jul 2021 07:05:09 -0500 [thread overview]
Message-ID: <20210720120509.66igh3goqoopkinv@extinct> (raw)
In-Reply-To: <d5d614f4-339b-59a1-bd29-6c78d09f2d89@ti.com>
On 10:46-20210720, Lokesh Vutla wrote:
>
>
> On 19/07/21 8:53 pm, Nishanth Menon wrote:
> > On 14:24-20210719, Lokesh Vutla wrote:
> >> ecap0 can be configured to use pad ECAP0_IN_APWM_OUT (D18) which has a
> >> signal connected to Pin 1 of J3. Add support for adding this pinmux so
> >> that pwm can be observed on pin 1 of Header J3
> >>
> >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> >> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> >> ---
> >> arch/arm64/boot/dts/ti/k3-am642-sk.dts | 12 ++++++++++++
> >> 1 file changed, 12 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> >> index d3aa2901e6fd..eb0d10e6e787 100644
> >> --- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> >> +++ b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> >> @@ -210,6 +210,12 @@ AM64X_IOPAD(0x0028, PIN_INPUT, 0) /* (M17) OSPI0_D7 */
> >> AM64X_IOPAD(0x0008, PIN_INPUT, 0) /* (N19) OSPI0_DQS */
> >> >;
> >> };
> >> +
> >> + main_ecap0_pins_default: main-ecap0-pins-default {
> >> + pinctrl-single,pins = <
> >> + AM64X_IOPAD(0x0270, PIN_INPUT, 0) /* (D18) ECAP0_IN_APWM_OUT */
> >> + >;
> >> + };
> >> };
> >>
> >> &mcu_uart0 {
> >> @@ -453,3 +459,9 @@ &pcie0_rc {
> >> &pcie0_ep {
> >> status = "disabled";
> >> };
> >> +
> >> +&ecap0 {
> >> + /* PWM is available on Pin 1 of header J3 */
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&main_ecap0_pins_default>;
> >> +};
> >> --
> >> 2.30.0
> >>
> >
> >
> > Do the other ecap and pwm nodes need to be disabled since they may not
> > be pinned out?
>
> Sure, Ill mark other ecap and epwm nodes as disabled. After looking at
> schematics, epwm4 and 5 is pinned out on RPI header. But the header will most
> likely be used for other use-cases. Shall I mark epwm4 and epwm5 disabled as
> well with a comment with this information?
Yes, please. Thanks.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2021-07-20 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 8:53 [PATCH 0/4] arm64: dts: ti: k3-am64: Add PWM nodes Lokesh Vutla
2021-07-19 8:53 ` [PATCH 1/4] arm64: dts: ti: k3-am64-main: Add epwm nodes Lokesh Vutla
2021-07-19 8:54 ` [PATCH 2/4] arm64: dts: ti: k3-am64-main: Add ecap pwm nodes Lokesh Vutla
2021-07-19 8:54 ` [PATCH 3/4] arm64: dts: ti: k3-am642-sk: Add ecap0 node Lokesh Vutla
2021-07-19 15:23 ` Nishanth Menon
2021-07-20 5:16 ` Lokesh Vutla
2021-07-20 12:05 ` Nishanth Menon [this message]
2021-07-19 8:54 ` [PATCH 4/4] arm64: dts: ti: k3-am642-evm: " Lokesh Vutla
2021-07-19 15:23 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720120509.66igh3goqoopkinv@extinct \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).