From: Jakub Kicinski <kuba@kernel.org>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: davem@davemloft.net, roopa@nvidia.com, nikolay@nvidia.com,
yoshfuji@linux-ipv6.org, dsahern@kernel.org, courmisch@gmail.com,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
johannes@sipsolutions.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org,
linux-decnet-user@lists.sourceforge.net,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 0/4] Remove rtnetlink_send() in rtnetlink
Date: Tue, 20 Jul 2021 12:44:27 +0200 [thread overview]
Message-ID: <20210720124427.6b4e05a8@cakuba> (raw)
In-Reply-To: <20210719122158.5037-1-yajun.deng@linux.dev>
On Mon, 19 Jul 2021 20:21:54 +0800, Yajun Deng wrote:
> rtnetlink_send() is similar to rtnl_notify(), there is no need for two
> functions to do the same thing. we can remove rtnetlink_send() and
> modify rtnl_notify() to adapt more case.
>
> Patch1: remove rtnetlink_send() modify rtnl_notify() to adapt
> more case in rtnetlink.
> Path2,Patch3: Adjustment parameters in rtnl_notify().
> Path4: rtnetlink_send() already removed, use rtnl_notify() instead
> of rtnetlink_send().
You can't break compilation in between patches. Each step of the series
(each patch) must be self-contained, build, and work correctly.
Otherwise bisection becomes a nightmare.
Please also post series as a thread (patches in reply to the cover
letter), it seems that patchwork did not group the patches correctly
here.
next prev parent reply other threads:[~2021-07-20 10:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 12:21 [PATCH 0/4] Remove rtnetlink_send() in rtnetlink Yajun Deng
2021-07-20 10:44 ` Jakub Kicinski [this message]
2021-07-20 3:21 Yajun Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720124427.6b4e05a8@cakuba \
--to=kuba@kernel.org \
--cc=bridge@lists.linux-foundation.org \
--cc=courmisch@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=linux-decnet-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yajun.deng@linux.dev \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).