linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu@kernel.org>
To: Praveen Kumar <kumarpraveen@linux.microsoft.com>
Cc: Wei Liu <wei.liu@kernel.org>,
	linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
	kys@microsoft.com, haiyangz@microsoft.com,
	sthemmin@microsoft.com, decui@microsoft.com, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com,
	viremana@linux.microsoft.com, sunilmut@microsoft.com,
	nunodasneves@linux.microsoft.com
Subject: Re: [PATCH] hyperv: root partition faults writing to VP ASSIST MSR PAGE
Date: Tue, 20 Jul 2021 13:35:14 +0000	[thread overview]
Message-ID: <20210720133514.lurmus2lgffcldnq@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <fd70c8e5-f58c-640b-30b7-70c4e4a4861a@linux.microsoft.com>

On Tue, Jul 20, 2021 at 06:55:56PM +0530, Praveen Kumar wrote:
[...]
> > 
> >> +	if (hv_root_partition &&
> >> +	    ms_hyperv.features & HV_MSR_APIC_ACCESS_AVAILABLE) {
> > 
> > Is HV_MSR_APIC_ACCESS_AVAILABLE a root only flag? Shouldn't non-root
> > kernel check this too?
> 
> Yes, you are right. Will update this in v2. thanks.

Please split adding this check to its own patch.

Ideally one patch only does one thing.

Wei.

> 
> > 
> > Wei.
> > 
> 
> Regards,
> 
> ~Praveen.

  reply	other threads:[~2021-07-20 13:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 18:51 [PATCH] hyperv: root partition faults writing to VP ASSIST MSR PAGE Praveen Kumar
2021-07-20 11:20 ` Wei Liu
2021-07-20 13:25   ` Praveen Kumar
2021-07-20 13:35     ` Wei Liu [this message]
2021-07-20 16:20       ` Michael Kelley
2021-07-20 16:29         ` Wei Liu
2021-07-21  4:10           ` Michael Kelley
2021-07-21  7:12             ` Praveen Kumar
2021-07-21 10:10               ` Wei Liu
2021-07-21 11:32                 ` Praveen Kumar
2021-07-21 15:07                   ` Michael Kelley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210720133514.lurmus2lgffcldnq@liuwe-devbox-debian-v2 \
    --to=wei.liu@kernel.org \
    --cc=bp@alien8.de \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=hpa@zytor.com \
    --cc=kumarpraveen@linux.microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nunodasneves@linux.microsoft.com \
    --cc=sthemmin@microsoft.com \
    --cc=sunilmut@microsoft.com \
    --cc=tglx@linutronix.de \
    --cc=viremana@linux.microsoft.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).