linux-next: build failure after merge of the drm-tegra tree

linux-next: build failure after merge of the drm-tegra tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

Hi all,

After merging the drm-tegra tree, today's linux-next build (arm64
randconfig) failed like this:

ERROR: modpost: "sync_file_create" [drivers/gpu/host1x/host1x.ko] undefined!

Caused by commit

  ad0529424def ("gpu: host1x: Add DMA fence implementation")

This build has

# CONFIG_SYNC_FILE is not set
CONFIG_TEGRA_HOST1X=m

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH] gpu: host1x: Remove unused functions

[Mikko Perttunen]

Remove the host1x_fence_create_fd and host1x_fence_extract
functions that are not used anywhere. host1x_fence_create_fd
is additionally using sync_file_create without there being
a Kconfig dependency to SYNC_FILE, causing builds to fail.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
---
 drivers/gpu/host1x/fence.c | 43 --------------------------------------
 include/linux/host1x.h     |  1 -
 2 files changed, 44 deletions(-)

diff --git a/drivers/gpu/host1x/fence.c b/drivers/gpu/host1x/fence.c
index 06c6b86237bd..5de4affcb918 100644
--- a/drivers/gpu/host1x/fence.c
+++ b/drivers/gpu/host1x/fence.c
@@ -164,46 +164,3 @@ struct dma_fence *host1x_fence_create(struct host1x_syncpt *sp, u32 threshold)
 	return &fence->base;
 }
 EXPORT_SYMBOL(host1x_fence_create);
-
-int host1x_fence_create_fd(struct host1x_syncpt *sp, u32 threshold)
-{
-	struct sync_file *file;
-	struct dma_fence *f;
-	int fd;
-
-	f = host1x_fence_create(sp, threshold);
-	if (IS_ERR(f))
-		return PTR_ERR(f);
-
-	fd = get_unused_fd_flags(O_CLOEXEC);
-	if (fd < 0) {
-		dma_fence_put(f);
-		return fd;
-	}
-
-	file = sync_file_create(f);
-	dma_fence_put(f);
-	if (!file)
-		return -ENOMEM;
-
-	fd_install(fd, file->file);
-
-	return fd;
-}
-EXPORT_SYMBOL(host1x_fence_create_fd);
-
-int host1x_fence_extract(struct dma_fence *fence, u32 *id, u32 *threshold)
-{
-	struct host1x_syncpt_fence *f;
-
-	if (fence->ops != &host1x_syncpt_fence_ops)
-		return -EINVAL;
-
-	f = container_of(fence, struct host1x_syncpt_fence, base);
-
-	*id = f->sp->id;
-	*threshold = f->threshold;
-
-	return 0;
-}
-EXPORT_SYMBOL(host1x_fence_extract);
diff --git a/include/linux/host1x.h b/include/linux/host1x.h
index 9b6784708f2e..2127762fc63d 100644
--- a/include/linux/host1x.h
+++ b/include/linux/host1x.h
@@ -171,7 +171,6 @@ void host1x_syncpt_release_vblank_reservation(struct host1x_client *client,
 					      u32 syncpt_id);
 
 struct dma_fence *host1x_fence_create(struct host1x_syncpt *sp, u32 threshold);
-int host1x_fence_extract(struct dma_fence *fence, u32 *id, u32 *threshold);
 
 /*
  * host1x channel
-- 
2.30.1

Re: linux-next: build failure after merge of the drm-tegra tree

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]

On Mon, Feb 04, 2019 at 11:12:41AM +1100, Stephen Rothwell wrote:
> Hi Thierry,
> 
> After merging the drm-tegra tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/gpu/host1x/cdma.c: In function 'host1x_cdma_wait_pushbuffer_space':
> drivers/gpu/host1x/cdma.c:279:13: error: 'struct host1x_cdma' has no member named 'sem'
>    down(&cdma->sem);
>              ^~
> 
> Caused by commit
> 
>   abb289796799 ("gpu: host1x: Use completion instead of semaphore")
> 
> interacting with commit
> 
>   db5652be58a9 ("gpu: host1x: Introduce support for wide opcodes")
> 
> I have used the drm-tegra tree from next-20190201 for today.

Oh my... so I go through all the build testing and then pull in the
seemlessly harmless fix and ruin everything...

I've fixed it up in my tree now, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

linux-next: build failure after merge of the drm-tegra tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]

Hi Thierry,

After merging the drm-tegra tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/gpu/host1x/cdma.c: In function 'host1x_cdma_wait_pushbuffer_space':
drivers/gpu/host1x/cdma.c:279:13: error: 'struct host1x_cdma' has no member named 'sem'
   down(&cdma->sem);
             ^~

Caused by commit

  abb289796799 ("gpu: host1x: Use completion instead of semaphore")

interacting with commit

  db5652be58a9 ("gpu: host1x: Introduce support for wide opcodes")

I have used the drm-tegra tree from next-20190201 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the drm-tegra tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]

Hi Thierry,

After merging the drm-tegra tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from include/asm-generic/bug.h:13:0,
                 from arch/arm/include/asm/bug.h:61,
                 from include/linux/bug.h:4,
                 from include/linux/scatterlist.h:5,
                 from include/linux/dma-buf.h:29,
                 from drivers/gpu/drm/tegra/gem.c:16:
drivers/gpu/drm/tegra/gem.c: In function 'tegra_bo_dumb_create':
drivers/gpu/drm/tegra/gem.c:265:39: error: dereferencing pointer to incomplete type
  min_pitch = round_up(min_pitch, tegra->pitch_align);
                                       ^
include/linux/kernel.h:62:46: note: in definition of macro '__round_mask'
 #define __round_mask(x, y) ((__typeof__(x))((y)-1))
                                              ^
drivers/gpu/drm/tegra/gem.c:265:14: note: in expansion of macro 'round_up'
  min_pitch = round_up(min_pitch, tegra->pitch_align);
              ^
drivers/gpu/drm/tegra/dc.c: In function 'tegra_dc_init':
drivers/gpu/drm/tegra/dc.c:1300:29: error: 'tegra' undeclared (first use in this function)
  if (dc->soc->pitch_align > tegra->pitch_align)
                             ^
drivers/gpu/drm/tegra/dc.c:1300:29: note: each undeclared identifier is reported only once for each function it appears in

Caused by commit 26861f43da4e ("drm/tegra: Properly align stride for
framebuffers").

I have used the drm-tegra tree from next-20140801 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build failure after merge of the drm-tegra tree

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

On Thu, Feb 27, 2014 at 12:53:57PM +1100, Stephen Rothwell wrote:
> Hi Thierry,
> 
> After merging the drm-tegra tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/gpu/drm/tegra/sor.c: In function 'tegra_sor_init':
> drivers/gpu/drm/tegra/sor.c:924:22: error: 'TEGRA_OUTPUT_LVDS' undeclared (first use in this function)
> 
> Caused by commit 765db82ce08a ("drm/tegra: Add eDP support").
> 
> I have used the drm-tegra tree from next-20140226 for today.

I've pushed out a fixed tree for linux-next.

Thanks,
Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the drm-tegra tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

Hi Thierry,

After merging the drm-tegra tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/tegra/sor.c: In function 'tegra_sor_init':
drivers/gpu/drm/tegra/sor.c:924:22: error: 'TEGRA_OUTPUT_LVDS' undeclared (first use in this function)

Caused by commit 765db82ce08a ("drm/tegra: Add eDP support").

I have used the drm-tegra tree from next-20140226 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]