linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: broonie@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: nolibc and __attribute__((__unused__))
Date: Wed, 21 Jul 2021 22:39:16 +0200	[thread overview]
Message-ID: <20210721203916.GC27330@1wt.eu> (raw)
In-Reply-To: <20210721203349.GA3209274@paulmck-ThinkPad-P17-Gen-1>

Hi Paul!

On Wed, Jul 21, 2021 at 01:33:49PM -0700, Paul E. McKenney wrote:
> Hello!
> 
> My guess is that I should ignore the following checkpatch complaint on
> the assumption that checkpatch doesn't realize that this is not built
> as part of the Linux kernel.  But if my guess is incorrect, please let
> me know, as it is a trivial change to make.
(...)
> WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__))
> #24: FILE: tools/include/nolibc/nolibc.h:2246:
> +static __attribute__((unused))

Yes you're totally right, we try to keep both trees in sync by minimizing
the differences between the two, so as long as that doesn't become a
problem I prefer to keep the warning than having to manually apply
future patches due to context differences.

Thanks!
Willy

  reply	other threads:[~2021-07-21 20:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 20:33 nolibc and __attribute__((__unused__)) Paul E. McKenney
2021-07-21 20:39 ` Willy Tarreau [this message]
2021-07-21 20:53   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210721203916.GC27330@1wt.eu \
    --to=w@1wt.eu \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).