From: Bjorn Helgaas <helgaas@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Marek Behún" <kabel@kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 2/3] PCI: aardvark: Fix checking for PIO status
Date: Wed, 21 Jul 2021 16:05:38 -0500 [thread overview]
Message-ID: <20210721210538.GA209436@bjorn-Precision-5520> (raw)
In-Reply-To: <20210720181155.lhmbrcvlnkhdj32o@pali>
On Tue, Jul 20, 2021 at 08:11:55PM +0200, Pali Rohár wrote:
> On Tuesday 20 July 2021 11:34:51 Bjorn Helgaas wrote:
> > On Tue, Jul 20, 2021 at 04:49:55PM +0200, Pali Rohár wrote:
> > > On Monday 19 July 2021 18:12:27 Bjorn Helgaas wrote:
> > > > On Fri, Jun 25, 2021 at 12:04:29PM +0100, Lorenzo Pieralisi wrote:
> > > > > On Thu, Jun 24, 2021 at 11:33:44PM +0200, Pali Rohár wrote:
> > > > >
> > > > > [...]
> > > > >
> > > > > > -static void advk_pcie_check_pio_status(struct advk_pcie *pcie)
> > > > > > +static int advk_pcie_check_pio_status(struct advk_pcie *pcie, u32 *val)
> > > > > > {
> > > > > > struct device *dev = &pcie->pdev->dev;
> > > > > > u32 reg;
> > > > > > @@ -472,15 +476,50 @@ static void advk_pcie_check_pio_status(struct advk_pcie *pcie)
> > > > > > status = (reg & PIO_COMPLETION_STATUS_MASK) >>
> > > > > > PIO_COMPLETION_STATUS_SHIFT;
> > > > > >
> > > > > > - if (!status)
> > > > > > - return;
> > > > > > -
> > > > > > + /*
> > > > > > + * According to HW spec, the PIO status check sequence as below:
> > > > > > + * 1) even if COMPLETION_STATUS(bit9:7) indicates successful,
> > > > > > + * it still needs to check Error Status(bit11), only when this bit
> > > > > > + * indicates no error happen, the operation is successful.
> > > > > > + * 2) value Unsupported Request(1) of COMPLETION_STATUS(bit9:7) only
> > > > > > + * means a PIO write error, and for PIO read it is successful with
> > > > > > + * a read value of 0xFFFFFFFF.
> > > > > > + * 3) value Completion Retry Status(CRS) of COMPLETION_STATUS(bit9:7)
> > > > > > + * only means a PIO write error, and for PIO read it is successful
> > > > > > + * with a read value of 0xFFFF0001.
> > > > > > + * 4) value Completer Abort (CA) of COMPLETION_STATUS(bit9:7) means
> > > > > > + * error for both PIO read and PIO write operation.
> > > > > > + * 5) other errors are indicated as 'unknown'.
> > > > > > + */
> > > > > > switch (status) {
> > > > > > + case PIO_COMPLETION_STATUS_OK:
> > > > > > + if (reg & PIO_ERR_STATUS) {
> > > > > > + strcomp_status = "COMP_ERR";
> > > > > > + break;
> > > > > > + }
> > > > > > + /* Get the read result */
> > > > > > + if (val)
> > > > > > + *val = advk_readl(pcie, PIO_RD_DATA);
> > > > > > + /* No error */
> > > > > > + strcomp_status = NULL;
> > > > > > + break;
> > > > > > case PIO_COMPLETION_STATUS_UR:
> > > > > > - strcomp_status = "UR";
> > > > > > + if (val) {
> > > > > > + /* For reading, UR is not an error status */
> > > > > > + *val = CFG_RD_UR_VAL;
> > > >
> > > > I think the comment is incorrect. Unsupported Request *is* an error
> > > > status. But most platforms log it and fabricate ~0 data
> > > > (CFG_RD_UR_VAL) to return to the CPU, and I think that's what you're
> > > > doing here. So I think the code is fine, but the "not an error
> > > > status" comment is wrong.
> > >
> > > Ok, and what we should driver set as return value for pci_ops.read
> > > callback in this case?
> >
> > On most platforms, pci_ops.read() does not check for failure, so it
> > returns PCIBIOS_SUCCESSFUL in this case.
>
> Ok. Most platforms do not check for failure. But it is generally
> correct? Probably more platforms do not provide error flag and only
> return value. But aardvark hw provides this kind error information, so
> should pci-aardvark's pci_ops.read() on error returns PCIBIOS_SUCCESSFUL
> on some other return value?
By all means, if you have the error information handy, return
PCIBIOS_DEVICE_NOT_FOUND or whatever you think is appropriate. Of
course, most callers of pci_read_config_word() et al don't check. I
think you should set the returned data to ~0 in this case, too.
next prev parent reply other threads:[~2021-07-21 21:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 21:33 [RESEND PATCH 0/3] PCI: aardvark: PIO fixes Pali Rohár
2021-06-24 21:33 ` [RESEND PATCH 1/3] PCI: aardvark: Fix checking for PIO Non-posted Request Pali Rohár
2021-06-24 21:33 ` [RESEND PATCH 2/3] PCI: aardvark: Fix checking for PIO status Pali Rohár
2021-06-25 11:04 ` Lorenzo Pieralisi
2021-06-25 11:21 ` Pali Rohár
2021-07-19 23:12 ` Bjorn Helgaas
2021-07-20 14:49 ` Pali Rohár
2021-07-20 16:34 ` Bjorn Helgaas
2021-07-20 18:11 ` Pali Rohár
2021-07-20 18:30 ` Bjorn Helgaas
2021-07-21 21:05 ` Bjorn Helgaas [this message]
2021-06-24 21:33 ` [RESEND PATCH 3/3] PCI: aardvark: Increase polling delay to 1.5s while waiting for PIO response Pali Rohár
2021-06-25 11:44 ` [RESEND PATCH 0/3] PCI: aardvark: PIO fixes Lorenzo Pieralisi
2021-07-22 14:40 ` [PATCH v2 0/4] " Pali Rohár
2021-07-22 14:40 ` [PATCH v2 1/4] PCI: aardvark: Fix checking for PIO status Pali Rohár
2021-07-22 14:40 ` [PATCH v2 2/4] PCI: aardvark: Increase polling delay to 1.5s while waiting for PIO response Pali Rohár
2021-07-22 14:40 ` [PATCH v2 3/4] PCI: pci-bridge-emul: Add PCIe Root Capabilities Register Pali Rohár
2021-07-22 14:40 ` [PATCH v2 4/4] PCI: aardvark: Fix reporting CRS value Pali Rohár
2021-08-05 9:54 ` [PATCH v2 0/4] PCI: aardvark: PIO fixes Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721210538.GA209436@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=kabel@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=pali@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).