linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: mika.penttila@gmail.com
To: linux-kernel@vger.kernel.org
Cc: lirongqing@baidu.com, pbonzini@redhat.com, mingo@redhat.com,
	peterz@infradead.org, kvm@vger.kernel.org,
	"Mika Penttilä" <mika.penttila@gmail.com>
Subject: [PATCH] is_core_idle() is using a wrong variable
Date: Thu, 22 Jul 2021 09:39:46 +0300	[thread overview]
Message-ID: <20210722063946.28951-1-mika.penttila@gmail.com> (raw)

From: Mika Penttilä <mika.penttila@gmail.com>

is_core_idle() was using a wrong variable in the loop test. Fix it.

Signed-off-by: Mika Penttilä <mika.penttila@gmail.com>
---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 44c452072a1b..30a6984a58f7 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1486,7 +1486,7 @@ static inline bool is_core_idle(int cpu)
 		if (cpu == sibling)
 			continue;
 
-		if (!idle_cpu(cpu))
+		if (!idle_cpu(sibling))
 			return false;
 	}
 #endif
-- 
2.17.1


             reply	other threads:[~2021-07-22  6:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22  6:39 mika.penttila [this message]
2021-07-28 10:41 ` [PATCH] is_core_idle() is using a wrong variable Peter Zijlstra
2021-07-28 11:50   ` Mel Gorman
2021-07-29  4:26   ` Pankaj Gupta
2021-08-05  9:34 ` [tip: sched/core] sched/numa: Fix is_core_idle() tip-bot2 for Mika Penttilä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210722063946.28951-1-mika.penttila@gmail.com \
    --to=mika.penttila@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lirongqing@baidu.com \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).