linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: wens@csie.org, robh+dt@kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: allwinner: h6: tanix-tx6: Add PIO power supplies
Date: Thu, 22 Jul 2021 10:21:37 +0200	[thread overview]
Message-ID: <20210722082137.2kgbirwtayq4bl7x@gilmour> (raw)
In-Reply-To: <20210721200832.916644-2-jernej.skrabec@gmail.com>

Hi,

On Wed, Jul 21, 2021 at 10:08:31PM +0200, Jernej Skrabec wrote:
> While there is no publicly available schematic of this board, it's not
> hard to determine voltage of GPIO port C, D and G (only ones which can
> be set).
> 
> Port C and G are used for MMC/SDIO communication, so they use 1.8 V
> power supply. It's not clear if port D is even used, but if it is, it's
> pretty safe to assume it uses 3.3 V power supply. Value read from PIO
> Group Withstand Voltage Mode Select register from within pre-installed
> Android agrees with that assesment.
> 
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> ---
>  .../boot/dts/allwinner/sun50i-h6-tanix-tx6.dts      | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> index be81330db14f..a1dd8f472cc8 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> @@ -32,6 +32,13 @@ hdmi_con_in: endpoint {
>  		};
>  	};
>  
> +	reg_vcc1v8: vcc1v8 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc1v8";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +	};
> +

I appreciate that the other 3.3V regulator has the same issue, but the
node name must reflect the class of the device. Maybe regulator-vcc1v8?

Maxime

  reply	other threads:[~2021-07-22  8:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 20:08 [PATCH 0/2] arm64: dts: allwinner: h6: tanix-tx6: Enable eMMC Jernej Skrabec
2021-07-21 20:08 ` [PATCH 1/2] arm64: dts: allwinner: h6: tanix-tx6: Add PIO power supplies Jernej Skrabec
2021-07-22  8:21   ` Maxime Ripard [this message]
2021-07-21 20:08 ` [PATCH 2/2] arm64: dts: allwinner: h6: tanix-tx6: enable emmc Jernej Skrabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210722082137.2kgbirwtayq4bl7x@gilmour \
    --to=maxime@cerno.tech \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    --subject='Re: [PATCH 1/2] arm64: dts: allwinner: h6: tanix-tx6: Add PIO power supplies' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).