From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C8A7C63793 for ; Thu, 22 Jul 2021 09:38:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E3C16120C for ; Thu, 22 Jul 2021 09:38:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231390AbhGVI5x (ORCPT ); Thu, 22 Jul 2021 04:57:53 -0400 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:41953 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231280AbhGVI5v (ORCPT ); Thu, 22 Jul 2021 04:57:51 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id BB3525816EA; Thu, 22 Jul 2021 05:38:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 22 Jul 2021 05:38:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=fPOCX/2GJ3M7cJqK5A8WsdKaQFZ TFDE51BgTgEgH6K4=; b=RjJE3ndxavrfIPS4AxsI8NhCYTRZCu9J+6gMqiZHzv+ Diw3Mwt0D6aQIDwV/oH4Z2GL7uAtLZvnFQNQ+XxRMBDx59IzLpcMZkYO/DN3C3Ps VwlzPu72jd5mT1yaNBt6TEMPSjFCTjnrzVkrQFGjnDy/EXdVspmmcJhh4SXDNiUN fpghmptooEg2VEs+QhUbwGqquri2e4YhfgLnTdI36uvaX+i9pCS/8viqbinfrdlp YYfjrQcQzJIicA1e8U+TJmrrBqC9d1K5+oBzonsncG5Uuybi7Q0msARZEB01UlTy ceZIoj2HEdXcJd2N7Osc5lwE/5app9iHRw15IGvkB2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=fPOCX/ 2GJ3M7cJqK5A8WsdKaQFZTFDE51BgTgEgH6K4=; b=bjQlXvnZC+CuosspSwIT1h dCMcanQY5a9Ly/wS/cDZTJmuu/lB5iOXOQVxL9pyi2eMf7J0v0Ad7HX8QfE/BgzJ Qpg22/XPgq1/DT3TbuQNXIS4ABXieAUizbdJZy9FX+vV/y64lSGwfGMt7GMwnmq7 vWU8YU7LREKX+akJBgPAUCjbpuWXNnzrib6enSEfwblc3Lc2/XW0WBh7xrElaM0K wNp8Fiogchedc3PfffxWCMey/1GBu6GA6q9KlTmwUeqxjEziDCBnU7FMCG9rzitA WlK6smoPgGPxnELKkTH0p3n3iZeNYokjuW8ElJawdp1j7U4lf+Yx3WkjhwD63f8g == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeeigdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Jul 2021 05:38:22 -0400 (EDT) Date: Thu, 22 Jul 2021 11:38:21 +0200 From: Maxime Ripard To: Sam Ravnborg Cc: Robert Foss , Andrzej Hajda , Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Thierry Reding , Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/10] drm/panel: raspberrypi-touchscreen: Prevent double-free Message-ID: <20210722093821.nnmcldjts2boxctu@gilmour> References: <20210720134525.563936-1-maxime@cerno.tech> <20210720134525.563936-9-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fgqdyjawfptivtlq" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fgqdyjawfptivtlq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 20, 2021 at 07:19:40PM +0200, Sam Ravnborg wrote: > Hi Maxime, > On Tue, Jul 20, 2021 at 03:45:23PM +0200, Maxime Ripard wrote: > > The mipi_dsi_device allocated by mipi_dsi_device_register_full() is > > already free'd on release. > >=20 > > Fixes: 2f733d6194bd ("drm/panel: Add support for the Raspberry Pi 7" To= uchscreen.") > > Signed-off-by: Maxime Ripard > > Reviewed-by: Sam Ravnborg Thanks, I applied it to drm-misc-fixes > I did a quick audit (as using grep mostly) to see if other panels had > the same bug, but did not find others. Yeah, the RaspberryPi panel seems to be the only odd DSI panel not controlled through DCS, and the other panels don't have to allocate the mipi-dsi device anyway. No bridge seems to have the issue though. Maxime --fgqdyjawfptivtlq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYPk8jQAKCRDj7w1vZxhR xYC+AQDajNGQcqMy8pCM0W9q6Ji0vEty86tBT6j+Tct9Hpp/6gD+MlZfK8T/f5sy i4i4KkiJB0fJmHJnkohwOa424wZFjAM= =NkL/ -----END PGP SIGNATURE----- --fgqdyjawfptivtlq--