From: Viresh Kumar <viresh.kumar@linaro.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Jason Wang" <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Jean-Philippe Brucker" <jean-philippe@linaro.org>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Bill Mills" <bill.mills@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Enrico Weigelt, metux IT consult" <info@metux.net>,
"Jie Deng" <jie.deng@intel.com>,
DTML <devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH V2 1/5] dt-bindings: virtio: Add binding for virtio devices
Date: Thu, 22 Jul 2021 16:02:14 +0530 [thread overview]
Message-ID: <20210722103214.vwdsaj6577pi4bdz@vireshk-i7> (raw)
In-Reply-To: <CAK8P3a1jqtu1BJmnfFLEgNXsPCfiTzd0sxwJBxdgNySmETBQSg@mail.gmail.com>
On 22-07-21, 12:28, Arnd Bergmann wrote:
> On Thu, Jul 22, 2021 at 11:57 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> >
> > Allow virtio device sub-nodes to be added to the virtio mmio or pci
> > nodes. The compatible property for virtio device must be of format
> > "virtio,<DID>", where DID is virtio device ID in hexadecimal format.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Looks good to me overall. One question would be for the exact format of
> the 'compatible' string. After seeing this version, I would slightly prefer
> "virtio,device22" over "virtio,22". I think in the previous version
> we had mentioned both, but not actually decided on which one to use.
Right, so there were few doubts I had.
- Should I use "device" as well or not.
- Should I use hex value or decimal.
I went with what's already done with USB/PCI, and so dropped device
and used hex values.
I don't have any strong opinions about using or dropping "device", I
am fine with whatever You/Rob suggest.
--
viresh
next prev parent reply other threads:[~2021-07-22 10:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 9:56 [PATCH V2 0/5] virtio: Add virtio-device bindings Viresh Kumar
2021-07-22 9:56 ` [PATCH V2 1/5] dt-bindings: virtio: Add binding for virtio devices Viresh Kumar
2021-07-22 10:28 ` Arnd Bergmann
2021-07-22 10:32 ` Viresh Kumar [this message]
2021-07-22 9:56 ` [PATCH V2 2/5] dt-bindings: i2c: Add bindings for i2c-virtio Viresh Kumar
2021-07-22 14:45 ` Wolfram Sang
2021-07-22 9:56 ` [PATCH V2 3/5] dt-bindings: gpio: Add bindings for gpio-virtio Viresh Kumar
2021-07-22 9:56 ` [PATCH V2 4/5] uapi: virtio_ids: Sync ids with specification Viresh Kumar
2021-07-22 9:56 ` [PATCH V2 5/5] virtio: Bind virtio device to device-tree node Viresh Kumar
2021-07-22 14:52 ` Arnd Bergmann
2021-07-23 1:30 ` Viresh Kumar
2021-07-23 6:11 ` [PATCH V2.1 " Viresh Kumar
2021-07-23 8:59 ` Arnd Bergmann
2021-07-23 10:33 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210722103214.vwdsaj6577pi4bdz@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=arnd@kernel.org \
--cc=bill.mills@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=info@metux.net \
--cc=jasowang@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=jie.deng@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=robh+dt@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).