From: Bjorn Helgaas <helgaas@kernel.org>
To: Christian Gmeiner <christian.gmeiner@gmail.com>
Cc: "Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI: dwc: do not ignore link errors
Date: Thu, 22 Jul 2021 11:38:45 -0500 [thread overview]
Message-ID: <20210722163845.GA314985@bjorn-Precision-5520> (raw)
In-Reply-To: <20210721171142.GA189373@bjorn-Precision-5520>
On Wed, Jul 21, 2021 at 12:11:42PM -0500, Bjorn Helgaas wrote:
> On Wed, Jul 21, 2021 at 05:28:21PM +0200, Christian Gmeiner wrote:
> > This fixes long boot delays of about 10 seconds.
> >
> > I am working on a device powered by an TI am65 SoC where
> > we have a PCIe expansion slot. If there is no PCIe device
> > connected I see boot delays caused by pci_host_probe(..).
Oh, and I forgot to mention: Please follow the convention of
capitalizing the first word of the subject (use "git log --oneline
drivers/pci/controller/dwc/pcie-designware-host.c" to see what the
convention is).
Also, the commit log does not actually say what the patch *does*.
Please include an imperative statement about what it does in the
commit log. https://chris.beams.io/posts/git-commit/ has good tips.
prev parent reply other threads:[~2021-07-22 16:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 15:28 [PATCH v2] PCI: dwc: do not ignore link errors Christian Gmeiner
2021-07-21 17:11 ` Bjorn Helgaas
2021-07-22 16:38 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210722163845.GA314985@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=christian.gmeiner@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).