* [PATCH] percpu: remove export of pcpu_base_addr
@ 2021-07-22 18:58 Greg Kroah-Hartman
2021-07-23 5:38 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-07-22 18:58 UTC (permalink / raw)
To: dennis, tj, cl, akpm; +Cc: linux-mm, linux-kernel, Greg Kroah-Hartman
This is not needed by any modules, so remove the export.
Cc: Dennis Zhou <dennis@kernel.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: Christoph Lameter <cl@linux.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
mm/percpu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/percpu.c b/mm/percpu.c
index 7f2e0151c4e2..a43039629aa4 100644
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -146,7 +146,6 @@ static unsigned int pcpu_high_unit_cpu __ro_after_init;
/* the address of the first chunk which starts with the kernel static area */
void *pcpu_base_addr __ro_after_init;
-EXPORT_SYMBOL_GPL(pcpu_base_addr);
static const int *pcpu_unit_map __ro_after_init; /* cpu -> unit */
const unsigned long *pcpu_unit_offsets __ro_after_init; /* cpu -> unit offset */
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] percpu: remove export of pcpu_base_addr
2021-07-22 18:58 [PATCH] percpu: remove export of pcpu_base_addr Greg Kroah-Hartman
@ 2021-07-23 5:38 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2021-07-23 5:38 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: dennis, tj, cl, akpm, linux-mm, linux-kernel
On Thu, Jul 22, 2021 at 08:58:14PM +0200, Greg Kroah-Hartman wrote:
> This is not needed by any modules, so remove the export.
Looks good. Note that all non-static users only want the delta,
so this could be cleaned up with a helper as well. Also
__addr_to_pcpu_ptr and __pcpu_ptr_to_addr__pcpu_ptr_to_addr are
never actually overriden by arch code, so we can remove the ifndef
there.
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-23 5:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22 18:58 [PATCH] percpu: remove export of pcpu_base_addr Greg Kroah-Hartman
2021-07-23 5:38 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).