From: "Krzysztof Wilczyński" <kw@linux.com>
To: "Cai,Huoqing" <caihuoqing@baidu.com>
Cc: "Derrick, Jonathan" <jonathan.derrick@intel.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] PCI: vmd: Make use of PCI_DEVICE_DATA() helper function
Date: Fri, 23 Jul 2021 04:00:13 +0200 [thread overview]
Message-ID: <20210723020013.GA2170028@rocinante> (raw)
In-Reply-To: <e44664317c2949e794497dc5f903f2a8@baidu.com>
Hi,
Thank you for sending the patch over!
> PATCH[2/2] has some extra indentation, please don't apply it ,
You might know this already, but just in case make sure to run the
"checkpatch.pl" script over the patch before submission.
> I'll send PATCH V2.
You mean v3? Make sure to include a changelog, if possible.
A small nitpick: the PCI_DEVICE_DATA() is technically a macro rather
than a function, so you could update both the subject line and the
commit message accordingly, if you want.
Also, since you are about to send another version, add period at the end
of the sentence in the commit message.
Aside of the above, it's a nice refactor, thank you!
Krzysztof
next prev parent reply other threads:[~2021-07-23 2:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 11:29 [PATCH 0/2] PCI: Make use of PCI_DEVICE_XXX() helper function Cai Huoqing
2021-07-22 11:29 ` [PATCH 1/2] PCI: Make use of PCI_DEVICE_SUB/_CLASS() " Cai Huoqing
2021-07-22 11:29 ` [PATCH 2/2] PCI: vmd: Make use of PCI_DEVICE_DATA() " Cai Huoqing
2021-07-22 16:45 ` Derrick, Jonathan
2021-07-23 1:34 ` Cai,Huoqing
2021-07-23 2:00 ` Krzysztof Wilczyński [this message]
2021-07-23 3:28 ` Cai,Huoqing
-- strict thread matches above, loose matches on Subject: below --
2021-07-22 11:19 [PATCH 0/2] PCI: Make use of PCI_DEVICE_XXX() " Cai Huoqing
2021-07-22 11:19 ` [PATCH 2/2] PCI: vmd: Make use of PCI_DEVICE_DATA() " Cai Huoqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723020013.GA2170028@rocinante \
--to=kw@linux.com \
--cc=caihuoqing@baidu.com \
--cc=jonathan.derrick@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).