From: Arnd Bergmann <arnd@kernel.org> To: Ingo Molnar <mingo@kernel.org> Cc: Arnd Bergmann <arnd@arndb.de>, Peter Zijlstra <peterz@infradead.org>, Valentin Schneider <valentin.schneider@arm.com>, linux-kernel@vger.kernel.org Subject: [PATCH] smpboot: remove duplicate inline keyword Date: Fri, 23 Jul 2021 11:16:13 +0200 [thread overview] Message-ID: <20210723091618.1750551-1-arnd@kernel.org> (raw) From: Arnd Bergmann <arnd@arndb.de> 'static inline void __always_inline' is one more 'inline' than needed, and it's in the wrong place as gcc points out when extra warnings are enabled: kernel/smpboot.c:50:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration] 50 | static inline void __always_inline idle_init(unsigned int cpu) Move it to the right place instead. Fixes: e9ba16e68cce ("smpboot: Mark idle_init() as __always_inlined to work around aggressive compiler un-inlining") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- kernel/smpboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/smpboot.c b/kernel/smpboot.c index 21b7953f8242..cf6acab78538 100644 --- a/kernel/smpboot.c +++ b/kernel/smpboot.c @@ -47,7 +47,7 @@ void __init idle_thread_set_boot_cpu(void) * * Creates the thread if it does not exist. */ -static inline void __always_inline idle_init(unsigned int cpu) +static __always_inline void idle_init(unsigned int cpu) { struct task_struct *tsk = per_cpu(idle_threads, cpu); -- 2.29.2
next reply other threads:[~2021-07-23 9:16 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-23 9:16 Arnd Bergmann [this message] 2021-07-23 15:27 ` Valentin Schneider
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210723091618.1750551-1-arnd@kernel.org \ --to=arnd@kernel.org \ --cc=arnd@arndb.de \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=peterz@infradead.org \ --cc=valentin.schneider@arm.com \ --subject='Re: [PATCH] smpboot: remove duplicate inline keyword' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).