From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB56AC432BE for ; Fri, 23 Jul 2021 09:16:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FB3160F26 for ; Fri, 23 Jul 2021 09:16:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232229AbhGWIft (ORCPT ); Fri, 23 Jul 2021 04:35:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:54070 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232226AbhGWIfs (ORCPT ); Fri, 23 Jul 2021 04:35:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4C69D60EC0; Fri, 23 Jul 2021 09:16:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627031782; bh=c6UxR2OHHZll1trbCSFWnnbvEGuBZe5cc3iYlJgBzJM=; h=From:To:Cc:Subject:Date:From; b=CnQFfD7WJCSzQ1j7aAuujYjlTN+x478CUI4n7HWH2klYxB/evTOFEtPwAx41rqI11 7BaCHggTBbC9j53kzSXm4uOO4X74Y4CI1exYlcE8Ah1Y3p5P/QX8ZZKTS136y7KLrX nteP740ceWczpQUANFcVvU5Z/qkLgmgMdt1GyUu87vl9ouPwXWZmg6jr9O4q9HOout ZOISPBUSYV4w/tZ5bnJ95VUsUuqJBz7h1ucbuxZCrQTmDizxVWLx8xa5s4STIJ1fd/ XtEPK9/BwoDY91e9pyk48svuoBhPc+PZybtceo6wAVqRxZl+159JujH6+U26h67aNg 2fuuuFcll56cg== From: Arnd Bergmann To: Ingo Molnar Cc: Arnd Bergmann , Peter Zijlstra , Valentin Schneider , linux-kernel@vger.kernel.org Subject: [PATCH] smpboot: remove duplicate inline keyword Date: Fri, 23 Jul 2021 11:16:13 +0200 Message-Id: <20210723091618.1750551-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann 'static inline void __always_inline' is one more 'inline' than needed, and it's in the wrong place as gcc points out when extra warnings are enabled: kernel/smpboot.c:50:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration] 50 | static inline void __always_inline idle_init(unsigned int cpu) Move it to the right place instead. Fixes: e9ba16e68cce ("smpboot: Mark idle_init() as __always_inlined to work around aggressive compiler un-inlining") Signed-off-by: Arnd Bergmann --- kernel/smpboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/smpboot.c b/kernel/smpboot.c index 21b7953f8242..cf6acab78538 100644 --- a/kernel/smpboot.c +++ b/kernel/smpboot.c @@ -47,7 +47,7 @@ void __init idle_thread_set_boot_cpu(void) * * Creates the thread if it does not exist. */ -static inline void __always_inline idle_init(unsigned int cpu) +static __always_inline void idle_init(unsigned int cpu) { struct task_struct *tsk = per_cpu(idle_threads, cpu); -- 2.29.2