From: Andrew Morton <akpm@linux-foundation.org>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/doc: Include highmem.h in kernel-doc
Date: Fri, 23 Jul 2021 13:32:06 -0700 [thread overview]
Message-ID: <20210723133206.9b3bc1edcc30f431269c9304@linux-foundation.org> (raw)
In-Reply-To: <20210722021843.2336117-1-willy@infradead.org>
On Thu, 22 Jul 2021 03:18:42 +0100 "Matthew Wilcox (Oracle)" <willy@infradead.org> wrote:
> There is lots of good documentation in highmem.h that isn't being pulled
> into the html documentation. Fix up a couple of minor glitches and
> include it.
>
> --- a/include/linux/highmem.h
> +++ b/include/linux/highmem.h
>
> ...
>
> @@ -156,6 +156,7 @@ static inline void *kmap_atomic(struct page *page);
> * the side effects of kmap_atomic(), i.e. reenabling pagefaults and
> * preemption.
> */
> +static inline void kunmap_atomic(void *addr);
>
> /* Highmem related interfaces for management code */
> static inline unsigned int nr_free_highpages(void);
This hunk broke the i386 allmodconfig build.
In file included from ./include/linux/highmem.h:14,
from ./include/linux/bio.h:8,
from ./include/linux/blkdev.h:18,
from ./include/linux/blk-cgroup.h:23,
from ./include/linux/writeback.h:14,
from ./include/linux/memcontrol.h:22,
from ./include/linux/swap.h:9,
from ./include/linux/suspend.h:5,
from arch/x86/kernel/asm-offsets.c:13:
./include/linux/highmem-internal.h:216:1: error: expected identifier or '(' before 'do'
216 | do { \
| ^~
./include/linux/highmem.h:122:20: note: in expansion of macro 'kunmap_atomic'
122 | static inline void kunmap_atomic(void *addr);
| ^~~~~~~~~~~~~
./include/linux/highmem-internal.h:219:3: error: expected identifier or '(' before 'while'
219 | } while (0)
| ^~~~~
./include/linux/highmem.h:122:20: note: in expansion of macro 'kunmap_atomic'
122 | static inline void kunmap_atomic(void *addr);
| ^~~~~~~~~~~~~
make[1]: *** [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1
make: *** [Makefile:1213: prepare0] Error 2
I think I can see what you were trying to do there. How about we
instead move the kunmap_atomic() kerneldoc to an appropriate place?
prev parent reply other threads:[~2021-07-23 20:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 2:18 [PATCH] mm/doc: Include highmem.h in kernel-doc Matthew Wilcox (Oracle)
2021-07-23 20:32 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723133206.9b3bc1edcc30f431269c9304@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).