From: Mark Brown <email@example.com> To: "Limonciello, Mario" <Mario.Limonciello@amd.com> Cc: "firstname.lastname@example.org" <email@example.com>, "Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>, "firstname.lastname@example.org" <email@example.com>, Liam Girdwood <firstname.lastname@example.org>, Jaroslav Kysela <email@example.com>, Takashi Iwai <firstname.lastname@example.org>, open list <email@example.com> Subject: Re: [PATCH v3 1/2] ASoC: amd: Don't show messages about deferred probing by default Date: Fri, 23 Jul 2021 15:00:39 +0100 [thread overview] Message-ID: <20210723140039.GD5221@sirena.org.uk> (raw) In-Reply-To: <SA0PR12MB45103F60E23D6BE8CF7E603DE2E59@SA0PR12MB4510.namprd12.prod.outlook.com> [-- Attachment #1: Type: text/plain, Size: 865 bytes --] On Fri, Jul 23, 2021 at 01:04:51PM +0000, Limonciello, Mario wrote: > > On Thu, Jul 22, 2021 at 08:27:27AM -0500, Mario Limonciello wrote: > > > This isn't useful to a user, especially as probing will run again. > > > Use the dev_err_probe helper to hide the deferrerd probing messages. > > The reason we have these error messages is that they are very useful to > > users if they ever find that the device isn't instantiating due to some > > missing dependency or something that leaves it stuck in probe deferral, > > they give some hint as to what might be wrong. > Right, but they should be at debugging level, if someone has a problem they > turn on dynamic debugging for the module and then can see these messages. Your commit message says that reporting the error isn't useful, I am flagging that it is useful to have the messages be available to people. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-07-23 14:01 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-22 13:27 Mario Limonciello 2021-07-22 13:27 ` [PATCH v3 2/2] ASoC: amd: Use dev_probe_err helper Mario Limonciello 2021-07-23 12:38 ` [PATCH v3 1/2] ASoC: amd: Don't show messages about deferred probing by default Mark Brown 2021-07-23 13:04 ` Limonciello, Mario 2021-07-23 14:00 ` Mark Brown [this message] 2021-07-23 17:01 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210723140039.GD5221@sirena.org.uk \ --firstname.lastname@example.org \ --cc=Mario.Limonciello@amd.com \ --cc=Vijendar.Mukunda@amd.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v3 1/2] ASoC: amd: Don'\''t show messages about deferred probing by default' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).