From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B9FC4338F for ; Fri, 23 Jul 2021 14:01:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F24B60E9C for ; Fri, 23 Jul 2021 14:01:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235346AbhGWNVR (ORCPT ); Fri, 23 Jul 2021 09:21:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:33204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235274AbhGWNUN (ORCPT ); Fri, 23 Jul 2021 09:20:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 30A8060EB4; Fri, 23 Jul 2021 14:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627048846; bh=gtOq6WhWlRMQEG1wyFj0l8XWjIydftj/Y35aNv9Ibuk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rARwCSNRKEfbzSjpuZ6yueEkwaeCJSCWCLxUA2SGzRRqVvxsjb99HruHmX2f3ITUA eft2dA65etzzcg7JolVO+XM7/q05X+JndqNYUmMiLyoXOrl040R8OQIgT7L/o8d3qA 40yIddoyRMeayS4+bmoMZqsWWiCRL9doFnGphEx3cYh4izcHctlCGWTyapSOzbuKrM MrTuh3XJ9r0M6yJp/OSJYdeJh+1P/wee7vb0wdFkX6WVKvyElxjB+Odh/pnBYp+R0b b5q8145hLKg8XSv6JBuZ655zW9YdPh5oyGn3GYPSo/4EdjhkDd+gORJFAThbW26Let izoulGQ23B7tg== Date: Fri, 23 Jul 2021 15:00:39 +0100 From: Mark Brown To: "Limonciello, Mario" Cc: "alsa-devel@alsa-project.org" , "Mukunda, Vijendar" , "markpearson@lenovo.com" , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , open list Subject: Re: [PATCH v3 1/2] ASoC: amd: Don't show messages about deferred probing by default Message-ID: <20210723140039.GD5221@sirena.org.uk> References: <20210722132731.13264-1-mario.limonciello@amd.com> <20210723123847.GB5221@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1sNVjLsmu1MXqwQ/" Content-Disposition: inline In-Reply-To: X-Cookie: Integrity has no need for rules. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --1sNVjLsmu1MXqwQ/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jul 23, 2021 at 01:04:51PM +0000, Limonciello, Mario wrote: > > On Thu, Jul 22, 2021 at 08:27:27AM -0500, Mario Limonciello wrote: > > > This isn't useful to a user, especially as probing will run again. > > > Use the dev_err_probe helper to hide the deferrerd probing messages. > > The reason we have these error messages is that they are very useful to > > users if they ever find that the device isn't instantiating due to some > > missing dependency or something that leaves it stuck in probe deferral, > > they give some hint as to what might be wrong. > Right, but they should be at debugging level, if someone has a problem they > turn on dynamic debugging for the module and then can see these messages. Your commit message says that reporting the error isn't useful, I am flagging that it is useful to have the messages be available to people. --1sNVjLsmu1MXqwQ/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmD6y4cACgkQJNaLcl1U h9Dl7gf9EwtHg6Jq5Oc8xZqGS3b1Kfc+fqNmXfpv1/0NXIKa/hOJ0hBu66ssoBeE Y6RRvEmsMMjYgyAavhPkm8fhBy9KopJkVpKx1rHoei6R4nGuxHDijT4baC6dOT9n GKUioqcKo+E5b8zZ+CBv+pkaejDu138/RBRnjNepjwtaaRa2m5xmV7St0lyCzvnG cuogRLKm3m65SphnfPZz3CO4TdqwtibbNUjkFbJYhmhDMoirJz2tuOO+66R+fL9c GC5tPK4NB5JO3tu0I/ZCUwxNAe4IScjsSv3DC0q6ZR+fBsQhyDJgeXNRppvwXPG/ J+AvvEmddNGms2U09LSSWGnevgpF6g== =h35f -----END PGP SIGNATURE----- --1sNVjLsmu1MXqwQ/--