From: Mark Brown <firstname.lastname@example.org> To: Richard Fitzgerald <email@example.com> Cc: Pierre-Louis Bossart <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, Lucas Tanure <firstname.lastname@example.org> Subject: Re: [PATCH] ASoC: dapm: Revert "use component prefix when checking widget names" Date: Fri, 23 Jul 2021 16:24:03 +0100 [thread overview] Message-ID: <20210723152403.GH5221@sirena.org.uk> (raw) In-Reply-To: <email@example.com> [-- Attachment #1: Type: text/plain, Size: 968 bytes --] On Fri, Jul 23, 2021 at 04:17:26PM +0100, Richard Fitzgerald wrote: > On 22/07/2021 10:55, Richard Fitzgerald wrote: > > On 05/07/2021 17:50, Mark Brown wrote: > > I don't mind if someone wants to change the core dapm functions if that > > is generally useful, providing that it also updates all callers of those > > functions to still work. > > Changing the behaviour of core code to fix the Realtek driver without > > updating other callers of those functions is a problem. > Just to point out this is breaking stuff right now. It's not just > theoretical. You took several weeks to respond to my review comment, I'm sure you can cope with waiting a day or two for a response to your followup (which I'm having trouble understanding TBH). It would probably help if you could specifically identify the problem you are seeing and where you're seeing it - as I said in my review comment there appears to be a misconception about how the APIs are expected to work. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-07-23 15:24 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-03 12:50 Richard Fitzgerald 2021-07-05 16:50 ` Mark Brown 2021-07-22 9:55 ` Richard Fitzgerald 2021-07-23 15:17 ` Richard Fitzgerald 2021-07-23 15:24 ` Mark Brown [this message] 2021-07-28 16:09 ` Mark Brown 2021-07-28 18:29 ` Richard Fitzgerald 2021-07-28 23:40 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210723152403.GH5221@sirena.org.uk \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] ASoC: dapm: Revert "use component prefix when checking widget names"' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).