From: Salah Triki <salah.triki@gmail.com>
To: Steffen Maier <maier@linux.ibm.com>
Cc: aacraid@microsemi.com,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
gregkh@linuxfoundation.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND] scsi: aacraid: aachba: replace if with max()
Date: Fri, 23 Jul 2021 18:22:35 +0100 [thread overview]
Message-ID: <20210723172235.GA78880@pc> (raw)
In-Reply-To: <09202d04-d066-a552-7a33-6c4c3b669107@linux.ibm.com>
On Fri, Jul 23, 2021 at 06:56:51PM +0200, Steffen Maier wrote:
> On 7/22/21 7:32 PM, Salah Triki wrote:
> > Replace if with max() in order to make code more clean.
> >
> > Signed-off-by: Salah Triki <salah.triki@gmail.com>
> > ---
> > drivers/scsi/aacraid/aachba.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
> > index 46b8dffce2dd..330224f08fd3 100644
> > --- a/drivers/scsi/aacraid/aachba.c
> > +++ b/drivers/scsi/aacraid/aachba.c
> > @@ -485,8 +485,8 @@ int aac_get_containers(struct aac_dev *dev)
> > if (status != -ERESTARTSYS)
> > aac_fib_free(fibptr);
> >
> > - if (maximum_num_containers < MAXIMUM_NUM_CONTAINERS)
> > - maximum_num_containers = MAXIMUM_NUM_CONTAINERS;
> > + maximum_num_containers = max(maximum_num_containers, MAXIMUM_NUM_CONTAINERS);
> > +
>
> Haven't really looked closely, but isn't the old code more like a min()
> rather than a max()? maximum_num_containers being at least
> MAXIMUM_NUM_CONTAINERS or higher?
>
In the old code, maximum_num_containers gets the value MAXIMUM_NUM_CONTAINERS if
it is less than this value.
Thanx
next prev parent reply other threads:[~2021-07-23 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 17:32 [RESEND] scsi: aacraid: aachba: replace if with max() Salah Triki
2021-07-23 16:56 ` Steffen Maier
2021-07-23 17:19 ` Steffen Maier
2021-07-23 17:22 ` Salah Triki [this message]
2021-07-24 2:32 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723172235.GA78880@pc \
--to=salah.triki@gmail.com \
--cc=aacraid@microsemi.com \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maier@linux.ibm.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).