linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Alex Elder <elder@linaro.org>
Cc: bjorn.andersson@linaro.org, agross@kernel.org,
	davem@davemloft.net, kuba@kernel.org, evgreen@chromium.org,
	cpratapa@codeaurora.org, subashab@codeaurora.org,
	elder@kernel.org, linux-arm-msm@vger.kernel.org,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] dt-bindings: net: qcom,ipa: make imem interconnect optional
Date: Fri, 23 Jul 2021 14:52:52 -0600	[thread overview]
Message-ID: <20210723205252.GA2550230@robh.at.kernel.org> (raw)
In-Reply-To: <20210719212456.3176086-2-elder@linaro.org>

On Mon, Jul 19, 2021 at 04:24:54PM -0500, Alex Elder wrote:
> On some newer SoCs, the interconnect between IPA and SoC internal
> memory (imem) is not used.  Reflect this in the binding by moving
> the definition of the "imem" interconnect to the end and defining
> minItems to be 2 for both the interconnects and interconnect-names
> properties.
> 
> Signed-off-by: Alex Elder <elder@linaro.org>
> ---
>  .../devicetree/bindings/net/qcom,ipa.yaml      | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index ed88ba4b94df5..4853ab7017bd9 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -87,16 +87,18 @@ properties:
>        - const: ipa-setup-ready
>  
>    interconnects:
> +    minItems: 2
>      items:
> -      - description: Interconnect path between IPA and main memory
> -      - description: Interconnect path between IPA and internal memory
> -      - description: Interconnect path between IPA and the AP subsystem
> +      - description: Path leading to system memory
> +      - description: Path between the AP and IPA config space
> +      - description: Path leading to internal memory
>  
>    interconnect-names:
> +    minItems: 2
>      items:
>        - const: memory
> -      - const: imem
>        - const: config
> +      - const: imem

What about existing users? This will generate warnings. Doing this for 
the 2nd item would avoid the need for .dts updates:

- enum: [ imem, config ]

Rob

  reply	other threads:[~2021-07-23 20:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 21:24 [PATCH net-next 0/3] arm64: dts: qcom: DTS updates Alex Elder
2021-07-19 21:24 ` [PATCH net-next 1/3] dt-bindings: net: qcom,ipa: make imem interconnect optional Alex Elder
2021-07-23 20:52   ` Rob Herring [this message]
2021-07-26 15:59     ` Alex Elder
2021-07-28 15:33       ` Rob Herring
2021-08-03 12:24         ` Alex Elder
2021-08-03 18:05           ` Rob Herring
2021-07-19 21:24 ` [PATCH net-next 2/3] arm64: dts: qcom: sc7280: add IPA information Alex Elder
2021-07-19 21:24 ` [PATCH net-next 3/3] arm64: dts: qcom: sc7180: define ipa_fw_mem node Alex Elder
2021-07-20 14:20 ` [PATCH net-next 0/3] arm64: dts: qcom: DTS updates patchwork-bot+netdevbpf
2021-07-20 15:59   ` Bjorn Andersson
2021-07-26 15:44     ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210723205252.GA2550230@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=cpratapa@codeaurora.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=elder@kernel.org \
    --cc=elder@linaro.org \
    --cc=evgreen@chromium.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=subashab@codeaurora.org \
    --subject='Re: [PATCH net-next 1/3] dt-bindings: net: qcom,ipa: make imem interconnect optional' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).