From: Jonathan Cameron <jic23@kernel.org>
To: Ivan Mikhaylov <i.mikhaylov@yadro.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
<linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v5 0/3] iio: vcnl3020: add periodic mode, threshold options
Date: Sat, 24 Jul 2021 16:09:34 +0100 [thread overview]
Message-ID: <20210724160934.0ffede6e@jic23-huawei> (raw)
In-Reply-To: <20210722154420.915082-1-i.mikhaylov@yadro.com>
On Thu, 22 Jul 2021 18:44:17 +0300
Ivan Mikhaylov <i.mikhaylov@yadro.com> wrote:
> Add periodic mode enablement, high/low threshold options.
>
> Changes from v1:
> 1. Remove changes for hwmon driver and changes affecting
> vcnl3020 data structure.
> 2. Add enable/disable periodic mode functions.
>
> Changes from v2:
> 1. Minor fixes from Jonathan's comments.
>
> Changes from v3:
> 1. add DMA safe buffer in vcnl3020_data and use it on bulk_read/write
> calls
> 2. put vcnl3020_is_in_periodic_mode in vcnl3020_measure_proximity and
> vcnl3020_write_proxy_samp_freq
> 3. add mutex instead of iio_claim in vcnl3020_write_proxy_samp_freq
> 4. out_mutex -> err_unlock
>
> Changes from v4:
> 1. split into 3 patches - DMA safe buffer, periodic mode, change
> iio_claim/release on mutex.
> 2. add dev_err for regmap_read/write
Hi Ivan,
Given I only wanted some trivial changes in patch 2, I've made those whilst applying
rather that wasting either of our time with a v6. Please take a quick look to check
I didn't mess anything up!
Applied to the togreg branch of iio.git on kernel.org and pushed out as testing for
0-day to poke at it and see what it can find,
Thanks,
Jonathan
>
> Ivan Mikhaylov (3):
> iio: proximity: vcnl3020: add DMA safe buffer
> iio: proximity: vcnl3020: add periodic mode
> iio: proximity: vcnl3020: remove iio_claim/release_direct
>
> drivers/iio/proximity/vcnl3020.c | 354 +++++++++++++++++++++++++++++--
> 1 file changed, 338 insertions(+), 16 deletions(-)
>
prev parent reply other threads:[~2021-07-24 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 15:44 [PATCH v5 0/3] iio: vcnl3020: add periodic mode, threshold options Ivan Mikhaylov
2021-07-22 15:44 ` [PATCH v5 1/3] iio: proximity: vcnl3020: add DMA safe buffer Ivan Mikhaylov
2021-07-22 15:44 ` [PATCH v5 2/3] iio: proximity: vcnl3020: add periodic mode Ivan Mikhaylov
2021-07-24 15:07 ` Jonathan Cameron
2021-07-22 15:44 ` [PATCH v5 3/3] iio: proximity: vcnl3020: remove iio_claim/release_direct Ivan Mikhaylov
2021-07-24 15:09 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210724160934.0ffede6e@jic23-huawei \
--to=jic23@kernel.org \
--cc=i.mikhaylov@yadro.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).