From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 452D9C4320E for ; Sat, 24 Jul 2021 15:14:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2679360ED7 for ; Sat, 24 Jul 2021 15:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229927AbhGXOdi (ORCPT ); Sat, 24 Jul 2021 10:33:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:35196 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbhGXOdg (ORCPT ); Sat, 24 Jul 2021 10:33:36 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AE51960E0C; Sat, 24 Jul 2021 15:14:04 +0000 (UTC) Date: Sat, 24 Jul 2021 16:16:35 +0100 From: Jonathan Cameron To: Arnd Bergmann Cc: Andy Shevchenko , Sean Nyekjaer , Arnd Bergmann , Lars-Peter Clausen , Linus Walleij , Stephan Gerhold , Hans de Goede , Tomas Melin , Mike Looijmans , Alexandru Ardelean , linux-iio@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH] iio: accel: fxls8962af: fix i2c dependency Message-ID: <20210724161635.479e5238@jic23-huawei> In-Reply-To: References: <20210721151330.2176653-1-arnd@kernel.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Jul 2021 20:40:30 +0200 Arnd Bergmann wrote: > On Wed, Jul 21, 2021 at 7:34 PM Andy Shevchenko > wrote: > > On Wed, Jul 21, 2021 at 7:12 PM Arnd Bergmann wrote: > > > On Wed, Jul 21, 2021 at 5:52 PM Andy Shevchenko > > > wrote: > > > > On Wed, Jul 21, 2021 at 6:13 PM Arnd Bergmann wrote: > > > > ... > > > > > > > config FXLS8962AF > > > > > tristate > > > > > + depends on I2C || !I2C # cannot be built-in for modular I2C > > > > > > > > Can you enlighten me how this will not be a no-op? > > > > > > This part does nothing, it only causes a warning when FXLS8962AF > > > gets selected =y when I2C=m. > > > > This is something new to me. But shouldn't the other chunk guarantee > > that warning won't happen? > > Correct, it works without that, but if that fails after something changes, > this version would provide better diagnostics than the FXLS8962AF > core driver causing a link failure, and I found it documents better > why the other driver needs the dependency. > > Let me know if you prefer me to resend the patch without this hunk. > > Arnd Hi Arnd, I didn't think of this particularly combination when we dealt with last build issue the workaround brought in. I've applied this to the fixes-togreg branch of iio.git as an immediately solution, but longer term we should think about just using a function pointer to allow us to move this into the i2c specific module. If we do that we can drop this complex build logic later. Thanks, Jonathan