From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A594C4338F for ; Sun, 25 Jul 2021 14:43:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1AA3E60F23 for ; Sun, 25 Jul 2021 14:43:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231226AbhGYOCu (ORCPT ); Sun, 25 Jul 2021 10:02:50 -0400 Received: from smtpbg128.qq.com ([106.55.201.39]:29331 "EHLO smtpbg587.qq.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231128AbhGYOCs (ORCPT ); Sun, 25 Jul 2021 10:02:48 -0400 X-QQ-mid: bizesmtp44t1627224156tk1hi3xv Received: from localhost.localdomain (unknown [125.70.163.19]) by esmtp6.qq.com (ESMTP) with id ; Sun, 25 Jul 2021 22:42:34 +0800 (CST) X-QQ-SSF: 0100000000800090B000B00A0000000 X-QQ-FEAT: 5gms5Di3ODilk7bZB1FAqNg7OrSrWZuX4IoQP5HGl6VzbmzPVkXoD7Y/1hmWv zVG0r+KHtjO767QifZNqHl0ccXJmBtpi8sqiUWs3bFUf+phU0RAwKIVZRfcZ/MFRDAF6C4e +uWBAIv54Mawpgm79M0bWp41cZ+4w9zRImrci9yZejpcMj9RsJTBp5ficv5VmlBLFv+4FU8 AnkR2mbD4fhgOsnv9nasdUEraXrKzWYG5u3tl8dqUfAvpkgIJmmLZGP9LEq54+wwDa6kDzG IGZnpgFcVc5JWEMviQtu1wSnKdPM8/hfpsW17V15UdHyNPNn1IPOQVyoyj07/0MGf69w== X-QQ-GoodBg: 0 From: Jason Wang To: khalasa@piap.pl Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Wang Subject: [PATCH] net: ixp4xx_hss: use dma_pool_zalloc Date: Sun, 25 Jul 2021 22:42:21 +0800 Message-Id: <20210725144221.24391-1-wangborong@cdjrlc.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:cdjrlc.com:qybgspam:qybgspam5 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The dma_pool_zalloc combines dma_pool_alloc/memset. Therefore, the dma_pool_alloc/memset can be replaced with dma_pool_zalloc which is more compact. Signed-off-by: Jason Wang --- drivers/net/wan/ixp4xx_hss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c index 3c51ab239fb2..2cebbfca0bd1 100644 --- a/drivers/net/wan/ixp4xx_hss.c +++ b/drivers/net/wan/ixp4xx_hss.c @@ -975,11 +975,10 @@ static int init_hdlc_queues(struct port *port) return -ENOMEM; } - port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL, + port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL, &port->desc_tab_phys); if (!port->desc_tab) return -ENOMEM; - memset(port->desc_tab, 0, POOL_ALLOC_SIZE); memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */ memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab)); -- 2.32.0