From: Mel Gorman <email@example.com> To: LKML <firstname.lastname@example.org> Cc: Ingo Molnar <email@example.com>, Peter Zijlstra <firstname.lastname@example.org>, Vincent Guittot <email@example.com>, Valentin Schneider <firstname.lastname@example.org>, Aubrey Li <email@example.com>, Mel Gorman <firstname.lastname@example.org> Subject: [RFC PATCH 0/9] Modify and/or delete SIS_PROP Date: Mon, 26 Jul 2021 11:22:38 +0100 [thread overview] Message-ID: <email@example.com> (raw) When scanning for an idle CPU, SIS_PROP limits the scan based on an average estimated idle time for a domain but it's a somewhat inconsistent and fuzzy heuristic. Idle time of a CPU does not necessarily correlate with idle time of a domain, scanning for an idle core is not throttled at all and successful scans are not accounted for. The first three patches are accounting patches to put some numbers on the scan efficiency. Ultimately, they may not be merged but they are useful for determining if a patch works as advertised. Patch 4 improves recent_used_cpu to reduce the amount of scanning that is done in absolute terms. Patch 5 notes that the target CPU has already been scanned with select_idle_cpu starts and therefore should be skipped. Patches 6-9 replace SIS_PROP with a scheme based on partially tracking idle CPUs, first proposed by Aubrey Li and modified by this series. It is likely to be the most controversial, not necessary a win, but the possibility was discussed. The series is likely to be split with one series being patches 4-5 and a second being patches 6-9. The series is not a univeral win or loss but there are some improvements and overall, scan efficiencies are improved. A limiting factor in the evaluation is that tracking the statistics is expensive on its own and all tests were run with schedstat enabled. Depending on how this RFC is received, testing would be done without schedstat and the series may be split. include/linux/sched/topology.h | 13 +++ kernel/sched/core.c | 7 +- kernel/sched/debug.c | 8 ++ kernel/sched/fair.c | 149 ++++++++++++++++++--------------- kernel/sched/features.h | 5 -- kernel/sched/idle.c | 5 ++ kernel/sched/sched.h | 17 +++- kernel/sched/stats.c | 10 ++- kernel/sched/topology.c | 3 +- 9 files changed, 133 insertions(+), 84 deletions(-) -- 2.26.2
next reply other threads:[~2021-07-26 10:23 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-26 10:22 Mel Gorman [this message] 2021-07-26 10:22 ` [PATCH 1/9] sched/fair: Track efficiency of select_idle_sibling Mel Gorman 2021-07-26 10:22 ` [PATCH 2/9] sched/fair: Track efficiency of task recent_used_cpu Mel Gorman 2021-07-26 10:22 ` [PATCH 3/9] sched/fair: Track efficiency of select_idle_core Mel Gorman 2021-07-26 10:22 ` [PATCH 4/9] sched/fair: Use prev instead of new target as recent_used_cpu Mel Gorman 2021-07-26 10:22 ` [PATCH 5/9] sched/fair: Avoid a second scan of target in select_idle_cpu Mel Gorman 2021-07-26 10:22 ` [PATCH 6/9] sched/fair: Make select_idle_cpu() proportional to cores Mel Gorman 2021-07-26 10:22 ` [PATCH 7/9] sched/fair: Enforce proportional scan limits when scanning for an idle core Mel Gorman 2021-08-02 10:52 ` Song Bao Hua (Barry Song) 2021-08-04 10:22 ` Mel Gorman 2021-07-26 10:22 ` [PATCH 8/9] sched/fair: select idle cpu from idle cpumask for task wakeup Mel Gorman 2021-08-02 10:41 ` Song Bao Hua (Barry Song) 2021-08-04 10:26 ` Mel Gorman 2021-08-05 0:23 ` Aubrey Li 2021-09-17 3:44 ` Barry Song 2021-09-17 4:15 ` Barry Song 2021-09-17 9:11 ` Aubrey Li 2021-09-17 13:35 ` Mel Gorman 2021-07-26 10:22 ` [PATCH 9/9] sched/core: Delete SIS_PROP and rely on the idle cpu mask Mel Gorman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [RFC PATCH 0/9] Modify and/or delete SIS_PROP' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).