From: Nikita Shubin <nikita.shubin@maquefel.me>
To: Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 1/8] iio: ep93xx: Prepare clock before using it
Date: Mon, 26 Jul 2021 14:50:45 +0300 [thread overview]
Message-ID: <20210726115058.23729-2-nikita.shubin@maquefel.me> (raw)
In-Reply-To: <20210726115058.23729-1-nikita.shubin@maquefel.me>
From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch
to Common Clock Framework, otherwise the following is visible:
WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:1011 clk_core_enable+0x9c/0xbc
Enabling unprepared ep93xx-adc
...
Hardware name: Cirrus Logic EDB9302 Evaluation Board
unwind_backtrace) from [<c000c590>] (show_stack+0x10/0x18)
...
clk_core_enable
clk_core_enable_lock
ep93xx_adc_probe
...
ep93xx-adc ep93xx-adc: Cannot enable clock
ep93xx-adc: probe of ep93xx-adc failed with error -108
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
drivers/iio/adc/ep93xx_adc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/adc/ep93xx_adc.c b/drivers/iio/adc/ep93xx_adc.c
index c08ab3c6dfaf..5c85257b814c 100644
--- a/drivers/iio/adc/ep93xx_adc.c
+++ b/drivers/iio/adc/ep93xx_adc.c
@@ -207,7 +207,7 @@ static int ep93xx_adc_probe(struct platform_device *pdev)
*/
}
- ret = clk_enable(priv->clk);
+ ret = clk_prepare_enable(priv->clk);
if (ret) {
dev_err(&pdev->dev, "Cannot enable clock\n");
return ret;
@@ -215,7 +215,7 @@ static int ep93xx_adc_probe(struct platform_device *pdev)
ret = iio_device_register(iiodev);
if (ret)
- clk_disable(priv->clk);
+ clk_disable_unprepare(priv->clk);
return ret;
}
@@ -226,7 +226,7 @@ static int ep93xx_adc_remove(struct platform_device *pdev)
struct ep93xx_adc_priv *priv = iio_priv(iiodev);
iio_device_unregister(iiodev);
- clk_disable(priv->clk);
+ clk_disable_unprepare(priv->clk);
return 0;
}
--
2.26.2
next prev parent reply other threads:[~2021-07-26 11:51 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 11:50 [PATCH 0/8] arm: ep93xx: CCF conversion Nikita Shubin
2021-07-26 11:50 ` Nikita Shubin [this message]
2021-07-26 11:50 ` [PATCH 2/8] spi: spi-ep93xx: Prepare clock before using it Nikita Shubin
2021-07-26 12:01 ` Mark Brown
2021-07-26 11:50 ` [PATCH 3/8] Input: ep93xx_keypad: " Nikita Shubin
2021-07-26 11:50 ` [PATCH 4/8] video: ep93xx: " Nikita Shubin
2021-07-26 11:50 ` [PATCH 5/8] dmaengine: " Nikita Shubin
2021-07-26 11:50 ` [PATCH 6/8] ASoC: cirrus: i2s: " Nikita Shubin
2021-07-26 11:50 ` [PATCH 7/8] pwm: ep93xx: " Nikita Shubin
2021-07-26 11:50 ` [PATCH 8/8] ep93xx: clock: convert in-place to COMMON_CLK Nikita Shubin
2021-07-26 11:57 ` Alexander Sverdlin
2021-07-26 13:59 ` [PATCH v2 0/8] arm: ep93xx: CCF conversion Nikita Shubin
2021-07-26 13:59 ` [PATCH v2 1/8] iio: ep93xx: Prepare clock before using it Nikita Shubin
2021-07-26 13:59 ` [PATCH v2 2/8] spi: spi-ep93xx: " Nikita Shubin
2021-07-26 16:51 ` Mark Brown
2021-08-02 7:36 ` Alexander Sverdlin
2021-09-13 21:36 ` Alexander Sverdlin
2021-09-13 21:37 ` Alexander Sverdlin
2021-09-14 10:32 ` Mark Brown
2021-07-26 13:59 ` [PATCH v2 3/8] Input: ep93xx_keypad: " Nikita Shubin
2021-07-26 13:59 ` [PATCH v2 4/8] video: ep93xx: " Nikita Shubin
2021-07-26 13:59 ` [PATCH v2 5/8] dmaengine: " Nikita Shubin
2021-08-02 6:57 ` Vinod Koul
2021-07-26 13:59 ` [PATCH v2 6/8] ASoC: cirrus: i2s: " Nikita Shubin
2021-07-26 16:51 ` Mark Brown
2021-09-13 21:43 ` Alexander Sverdlin
2021-10-12 7:25 ` Alexander Sverdlin
2021-10-12 10:40 ` Mark Brown
2021-07-26 13:59 ` [PATCH v2 7/8] pwm: ep93xx: " Nikita Shubin
2021-07-26 13:59 ` [PATCH v2 8/8] ep93xx: clock: convert in-place to COMMON_CLK Nikita Shubin
2021-10-12 8:03 ` Alexander Sverdlin
2021-10-12 8:29 ` Arnd Bergmann
2021-10-12 8:37 ` Alexander Sverdlin
2021-10-12 9:05 ` Arnd Bergmann
2021-10-12 10:26 ` Mark Brown
2021-10-12 10:36 ` Alexander Sverdlin
2021-10-12 10:43 ` Mark Brown
2021-10-12 11:03 ` Alexander Sverdlin
2021-10-12 11:21 ` Mark Brown
2021-10-12 11:26 ` Alexander Sverdlin
2021-10-12 11:30 ` Geert Uytterhoeven
2021-10-12 12:39 ` Arnd Bergmann
2021-10-12 12:57 ` Alexander Sverdlin
2021-10-15 22:32 ` Mark Brown
2021-08-03 22:35 ` (subset) [PATCH v2 0/8] arm: ep93xx: CCF conversion Mark Brown
2021-07-31 22:04 ` [PATCH " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726115058.23729-2-nikita.shubin@maquefel.me \
--to=nikita.shubin@maquefel.me \
--cc=Jonathan.Cameron@huawei.com \
--cc=alexander.sverdlin@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).