From: Mark Brown <broonie@kernel.org>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
David Lechner <david@lechnology.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: do not call regmap_debugfs_init() from regmap_attach_dev()
Date: Mon, 26 Jul 2021 13:00:13 +0100 [thread overview]
Message-ID: <20210726120013.GF4670@sirena.org.uk> (raw)
In-Reply-To: <20210726073627.31589-1-matthias.schiffer@ew.tq-group.com>
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
On Mon, Jul 26, 2021 at 09:36:27AM +0200, Matthias Schiffer wrote:
> lacking) understanding of the semantics aside, the fact that
> regmap_attach_dev() is setting fields on the shared regmap without any
> kind of locking is at least suspicious.
BTW there shouldn't be any harm in adding locking, but we're really
hoping that it shouldn't be required here as the caller ought to be
doing coordination which means things are single threaded anyway so we
didn't bother.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-07-26 12:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 7:36 [PATCH] regmap: do not call regmap_debugfs_init() from regmap_attach_dev() Matthias Schiffer
2021-07-26 11:47 ` Mark Brown
2021-07-26 12:01 ` Matthias Schiffer
2021-07-26 12:11 ` Mark Brown
2021-07-26 12:18 ` Matthias Schiffer
2021-07-26 18:48 ` Mark Brown
2021-07-27 12:24 ` (EXT) " Matthias Schiffer
2021-07-27 17:08 ` Mark Brown
2021-07-28 9:13 ` Matthias Schiffer
2021-07-26 12:00 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726120013.GF4670@sirena.org.uk \
--to=broonie@kernel.org \
--cc=david@lechnology.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).