From: Rob Herring <robh@kernel.org>
To: Artjom Vejsel <akawolf0@gmail.com>
Cc: thierry.reding@gmail.com, sam@ravnborg.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, paul@crapouillou.net
Subject: Re: [PATCH v3 2/3] dt-bindings: Add DT bindings for QiShenglong Gopher 2b panel
Date: Mon, 26 Jul 2021 16:51:44 -0600 [thread overview]
Message-ID: <20210726225144.GA1020985@robh.at.kernel.org> (raw)
In-Reply-To: <20210725221527.1771892-3-akawolf0@gmail.com>
On Mon, Jul 26, 2021 at 01:15:26AM +0300, Artjom Vejsel wrote:
> Add DT bindings for QiShenglong Gopher 2b 4.3" 480(RGB)x272 TFT LCD panel.
>
> Signed-off-by: Artjom Vejsel <akawolf0@gmail.com>
> ---
> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 3624363938dd..e7f3db118c5d 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -244,6 +244,8 @@ properties:
> - powertip,ph800480t013-idf02
> # QiaoDian XianShi Corporation 4"3 TFT LCD panel
> - qiaodian,qd43003c0-40
> + # Shenzhen QiShenglong Industrialist Co., Ltd. Gopher 2b 4.3" 480(RGB)x272 TFT LCD panel
> + - qishenglong,gopher2b-lcd-panel
Does 'gopher2b' refer to anything besides this panel? If not, then
'-lcd-panel' is redundant. Otherwise, '-panel' is redundant. Every LCD
is a panel.
> # Rocktech Displays Ltd. RK101II01D-CT 10.1" TFT 1280x800
> - rocktech,rk101ii01d-ct
> # Rocktech Display Ltd. RK070ER9427 800(RGB)x480 TFT LCD panel
> --
> 2.32.0
>
>
next prev parent reply other threads:[~2021-07-26 22:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 22:15 [PATCH v3 0/3] add Gopher 2b LCD panel Artjom Vejsel
2021-07-25 22:15 ` [PATCH v3 1/3] dt-bindings: Add QiShenglong vendor prefix Artjom Vejsel
2021-07-25 23:06 ` Paul Cercueil
2021-07-26 22:49 ` Rob Herring
2021-07-25 22:15 ` [PATCH v3 2/3] dt-bindings: Add DT bindings for QiShenglong Gopher 2b panel Artjom Vejsel
2021-07-25 23:06 ` Paul Cercueil
2021-07-26 22:51 ` Rob Herring [this message]
2021-07-25 22:15 ` [PATCH v3 3/3] drm/panel-simple: add Gopher 2b LCD panel Artjom Vejsel
2021-07-25 23:07 ` Paul Cercueil
2021-07-26 9:02 ` Paul Cercueil
2021-07-26 11:11 ` Artjom Vejsel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726225144.GA1020985@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=akawolf0@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).