From: Zenghui Yu <yuzenghui@huawei.com>
To: <linux-wireless@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <zajec5@gmail.com>, <kvalo@codeaurora.org>, <hauke@hauke-m.de>,
<linville@tuxdriver.com>, <wanghaibin.wang@huawei.com>,
Zenghui Yu <yuzenghui@huawei.com>
Subject: [PATCH 2/2] bcma: Drop the unused parameter of bcma_scan_read32()
Date: Tue, 27 Jul 2021 10:52:32 +0800 [thread overview]
Message-ID: <20210727025232.663-3-yuzenghui@huawei.com> (raw)
In-Reply-To: <20210727025232.663-1-yuzenghui@huawei.com>
As it had never been used since the initial commit 8369ae33b705 ("bcma: add
Broadcom specific AMBA bus driver").
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
drivers/bcma/scan.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/bcma/scan.c b/drivers/bcma/scan.c
index d49e7c0de2b6..26d12a7e6ca0 100644
--- a/drivers/bcma/scan.c
+++ b/drivers/bcma/scan.c
@@ -141,8 +141,7 @@ static const char *bcma_device_name(const struct bcma_device_id *id)
return "UNKNOWN";
}
-static u32 bcma_scan_read32(struct bcma_bus *bus, u8 current_coreidx,
- u16 offset)
+static u32 bcma_scan_read32(struct bcma_bus *bus, u16 offset)
{
return readl(bus->mmio + offset);
}
@@ -443,7 +442,7 @@ void bcma_detect_chip(struct bcma_bus *bus)
bcma_scan_switch_core(bus, BCMA_ADDR_BASE);
- tmp = bcma_scan_read32(bus, 0, BCMA_CC_ID);
+ tmp = bcma_scan_read32(bus, BCMA_CC_ID);
chipinfo->id = (tmp & BCMA_CC_ID_ID) >> BCMA_CC_ID_ID_SHIFT;
chipinfo->rev = (tmp & BCMA_CC_ID_REV) >> BCMA_CC_ID_REV_SHIFT;
chipinfo->pkg = (tmp & BCMA_CC_ID_PKG) >> BCMA_CC_ID_PKG_SHIFT;
@@ -465,7 +464,7 @@ int bcma_bus_scan(struct bcma_bus *bus)
if (bus->nr_cores)
return 0;
- erombase = bcma_scan_read32(bus, 0, BCMA_CC_EROM);
+ erombase = bcma_scan_read32(bus, BCMA_CC_EROM);
if (bus->hosttype == BCMA_HOSTTYPE_SOC) {
eromptr = ioremap(erombase, BCMA_CORE_SIZE);
if (!eromptr)
--
2.19.1
prev parent reply other threads:[~2021-07-27 2:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 2:52 two small bcma patches Zenghui Yu
2021-07-27 2:52 ` [PATCH 1/2] bcma: Fix memory leak for internally-handled cores Zenghui Yu
2021-08-21 3:28 ` Zenghui Yu
2021-08-21 10:05 ` Kalle Valo
2021-08-23 3:56 ` Zenghui Yu
2021-08-29 11:45 ` Kalle Valo
2021-07-27 2:52 ` Zenghui Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210727025232.663-3-yuzenghui@huawei.com \
--to=yuzenghui@huawei.com \
--cc=hauke@hauke-m.de \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wanghaibin.wang@huawei.com \
--cc=zajec5@gmail.com \
--subject='Re: [PATCH 2/2] bcma: Drop the unused parameter of bcma_scan_read32()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).