From: Jarkko Sakkinen <jarkko@kernel.org>
To: Adrian Ratiu <adrian.ratiu@collabora.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH 2/2] char: tpm: cr50_i2c: convert to new probe interface
Date: Tue, 27 Jul 2021 06:08:18 +0300 [thread overview]
Message-ID: <20210727030818.m5opmt7h2r4boh7s@kernel.org> (raw)
In-Reply-To: <20210723184150.2596604-2-adrian.ratiu@collabora.com>
On Fri, Jul 23, 2021 at 09:41:50PM +0300, Adrian Ratiu wrote:
> Way back when this driver was written the i2c framework
Nit: I2C (not i2c)
> used to insist an ID table be defined even if the driver
> did not use it in favor of ACPI/OF matching, so it was
> added just to placate the hard i2c framework requirement.
Ditto.
> This is no longer the case so we can drop the table and
> also convert the driver to the new probe interface.
>
> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
> ---
> drivers/char/tpm/tpm_tis_i2c_cr50.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_tis_i2c_cr50.c b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> index 44dde2fbe2fb..c89278103703 100644
> --- a/drivers/char/tpm/tpm_tis_i2c_cr50.c
> +++ b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> @@ -639,12 +639,6 @@ static const struct tpm_class_ops cr50_i2c = {
> .req_canceled = &tpm_cr50_i2c_req_canceled,
> };
>
> -static const struct i2c_device_id cr50_i2c_table[] = {
> - {"cr50_i2c", 0},
> - {}
> -};
> -MODULE_DEVICE_TABLE(i2c, cr50_i2c_table);
> -
> #ifdef CONFIG_ACPI
> static const struct acpi_device_id cr50_i2c_acpi_id[] = {
> { "GOOG0005", 0 },
> @@ -670,8 +664,7 @@ MODULE_DEVICE_TABLE(of, of_cr50_i2c_match);
> * - 0: Success.
> * - -errno: A POSIX error code.
> */
> -static int tpm_cr50_i2c_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int tpm_cr50_i2c_probe(struct i2c_client *client)
> {
> struct tpm_i2c_cr50_priv_data *priv;
> struct device *dev = &client->dev;
> @@ -774,8 +767,7 @@ static int tpm_cr50_i2c_remove(struct i2c_client *client)
> static SIMPLE_DEV_PM_OPS(cr50_i2c_pm, tpm_pm_suspend, tpm_pm_resume);
>
> static struct i2c_driver cr50_i2c_driver = {
> - .id_table = cr50_i2c_table,
> - .probe = tpm_cr50_i2c_probe,
> + .probe_new = tpm_cr50_i2c_probe,
> .remove = tpm_cr50_i2c_remove,
> .driver = {
> .name = "cr50_i2c",
> --
> 2.32.0
>
>
Otherwise, LGTM
/Jarkko
next prev parent reply other threads:[~2021-07-27 3:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 18:41 [PATCH 1/2] char: tpm: Kconfig: remove bad i2c cr50 select Adrian Ratiu
2021-07-23 18:41 ` [PATCH 2/2] char: tpm: cr50_i2c: convert to new probe interface Adrian Ratiu
2021-07-27 3:08 ` Jarkko Sakkinen [this message]
2021-07-27 3:06 ` [PATCH 1/2] char: tpm: Kconfig: remove bad i2c cr50 select Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210727030818.m5opmt7h2r4boh7s@kernel.org \
--to=jarkko@kernel.org \
--cc=adrian.ratiu@collabora.com \
--cc=jgg@ziepe.ca \
--cc=kernel@collabora.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).