From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E38EFC4320E for ; Tue, 27 Jul 2021 08:08:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC877603E9 for ; Tue, 27 Jul 2021 08:08:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235952AbhG0II4 (ORCPT ); Tue, 27 Jul 2021 04:08:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235847AbhG0IIw (ORCPT ); Tue, 27 Jul 2021 04:08:52 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7104FC061760 for ; Tue, 27 Jul 2021 01:08:52 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m8I8v-0006l6-4w; Tue, 27 Jul 2021 10:08:49 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1m8I8u-0005st-IP; Tue, 27 Jul 2021 10:08:48 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1m8I8u-0004F6-Hd; Tue, 27 Jul 2021 10:08:48 +0200 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de, Finn Thain , linux-m68k@lists.linux-m68k.org Subject: [PATCH 1/5] nubus: Simplify check in remove callback Date: Tue, 27 Jul 2021 10:08:36 +0200 Message-Id: <20210727080840.3550927-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210727080840.3550927-1-u.kleine-koenig@pengutronix.de> References: <20210727080840.3550927-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Patch-Hashes: v=1; h=sha256; i=TjLBJt0QGxFmp7SpMOjzQEIkuFPLuMwSswChhiWQZSU=; m=wXPfirdbvvcSYlx+JCUfR/1GbjenG0HiiYu5sgWWGUA=; p=Y7UBaaGsszQzvtKk/Xj3uSk938y5pFeeoLuZiSQOfmc=; g=c25b7253ee9694e5d77118adf90c05984d48eb27 X-Patch-Sig: m=pgp; i=u.kleine-koenig@pengutronix.de; s=0x0D2511F322BFAB1C1580266BE2DCDD9132669BD6; b=iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmD/vvEACgkQwfwUeK3K7AkflQf+NeZ PUIr85FBlIyUZiqYPoXkBBVVoe7rIOLiihzEf4bz18isSmVBY9Pj04XC7/oN4Y+uoiiFNbmV7yXWh VWprm4Yp+plvlP6pwNkotQEuPaKmgYFPZuTuKLnubTMtX2h0M8yCtPp4tDLX2xJNQ4RIptD8//YBC KoRGTtUJO0wAHre4LjAYMaqr8mIvtsKZ0sBfPeGp6Rg3eitFIJ3UaOwJIsSqYLM3uE+ywfVCYqtjv tgY440Bk0Qm3FoCBcWbk6Fv9g56AiW5XhfXS7On5BOue18M1xSEwdCrjA0VY7Pr6E2ygrd3HEiejx gM0MdZH9ASXxaxy3cri0OdkEEzy7Yqg== Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver core only calls a remove callback when the device was successfully bound (aka probed) before. So dev->driver is never NULL. Apart from that, the compiler might already assume dev->driver being non-NULL after to_nubus_driver(dev->driver) was called. Signed-off-by: Uwe Kleine-König --- drivers/nubus/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nubus/bus.c b/drivers/nubus/bus.c index d9d04f27f89b..17fad660032c 100644 --- a/drivers/nubus/bus.c +++ b/drivers/nubus/bus.c @@ -33,7 +33,7 @@ static void nubus_device_remove(struct device *dev) { struct nubus_driver *ndrv = to_nubus_driver(dev->driver); - if (dev->driver && ndrv->remove) + if (ndrv->remove) ndrv->remove(to_nubus_board(dev)); } -- 2.30.2