From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96EA0C4320E for ; Tue, 27 Jul 2021 08:23:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F61760F58 for ; Tue, 27 Jul 2021 08:23:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235975AbhG0IXq (ORCPT ); Tue, 27 Jul 2021 04:23:46 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:44772 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235977AbhG0IXm (ORCPT ); Tue, 27 Jul 2021 04:23:42 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 3F79E2214E; Tue, 27 Jul 2021 08:23:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1627374207; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e+oMesGkL6U9Ftyv/jPBGc6U/qcAAuGWRvwKofiTqRs=; b=e1hWaq8M94FhtLPK9Yqzq1PmLtaUX2abt/VSAxms46a1Pq3v6sVupz65havPR+0IzHP5AS F7tcOwNgnVgju3j4baV6stuE6rl+AzBSayg7KC5m+nAFWz/cMbEjTATEufQMtNIvLXK5mK IaXHCke87RgJPN5a8cFjLcr67b3753k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1627374207; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e+oMesGkL6U9Ftyv/jPBGc6U/qcAAuGWRvwKofiTqRs=; b=qVvIMDHZE+bbYi9dFvFuxqru7GxUXPmzo4/6Prqj7P5jDqi36kt6f2u2Z5Nw4jjwVUPc/e NyyP4uLl9QZjetBw== Received: from ds.suse.cz (ds.suse.cz [10.100.12.205]) by relay2.suse.de (Postfix) with ESMTP id 26BFAA3B81; Tue, 27 Jul 2021 08:23:27 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id EA8FEDA8CC; Tue, 27 Jul 2021 10:20:42 +0200 (CEST) Date: Tue, 27 Jul 2021 10:20:42 +0200 From: David Sterba To: Christoph Hellwig Cc: Andreas Gruenbacher , Gao Xiang , "Darrick J . Wong" , Matthew Wilcox , Huang Jianan , linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Andreas Gruenbacher Subject: Re: [PATCH v7] iomap: make inline data support more flexible Message-ID: <20210727082042.GI5047@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Christoph Hellwig , Andreas Gruenbacher , Gao Xiang , "Darrick J . Wong" , Matthew Wilcox , Huang Jianan , linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Andreas Gruenbacher References: <20210723174131.180813-1-hsiangkao@linux.alibaba.com> <20210725221639.426565-1-agruenba@redhat.com> <20210726110611.459173-1-agruenba@redhat.com> <20210726121702.GA528@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210726121702.GA528@lst.de> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 26, 2021 at 02:17:02PM +0200, Christoph Hellwig wrote: > > Subject: iomap: Support tail packing > > I can't say I like this "tail packing" language here when we have the > perfectly fine inline wording. Same for various comments in the actual > code. Yes please, don't call it tail-packing when it's an inline extent, we'll use that for btrfs eventually and conflating the two terms has been cofusing users. Except reiserfs, no linux filesystem does tail-packing.