From: Alex Williamson <alex.williamson@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Cai Huoqing <caihuoqing@baidu.com>,
jgg@ziepe.ca, eric.auger@redhat.com, kevin.tian@intel.com,
giovanni.cabiddu@intel.com, mgurtovoy@nvidia.com,
jannh@google.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio: Add "#ifdef CONFIG_MMU" for vma operations
Date: Tue, 27 Jul 2021 12:01:16 -0600 [thread overview]
Message-ID: <20210727120116.61ba8e25.alex.williamson@redhat.com> (raw)
In-Reply-To: <877dhb4svx.fsf@redhat.com>
On Tue, 27 Jul 2021 18:35:14 +0200
Cornelia Huck <cohuck@redhat.com> wrote:
> On Tue, Jul 27 2021, Cai Huoqing <caihuoqing@baidu.com> wrote:
>
> > Add "#ifdef CONFIG_MMU",
> > because vma mmap and vm_operations_struct depend on MMU
>
> vfio_pci already depends on MMU -- what problems are you trying to fix?
Exactly my question, we silenced the randconfig builds without
CONFIG_MMU in commit 2a55ca373501 ("vfio/pci: zap_vma_ptes() needs
MMU"). Surely there are prototypes for vma_area_struct regardless of
CONFIG_MMU and vfio-core having an mmap callback has no dependency on
vm_operations_struct. Thanks,
Alex
prev parent reply other threads:[~2021-07-27 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 3:40 [PATCH] vfio: Add "#ifdef CONFIG_MMU" for vma operations Cai Huoqing
2021-07-27 16:35 ` Cornelia Huck
2021-07-27 18:01 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210727120116.61ba8e25.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=caihuoqing@baidu.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=giovanni.cabiddu@intel.com \
--cc=jannh@google.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).