From: Dan Carpenter <dan.carpenter@oracle.com>
To: Salah Triki <salah.triki@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Fabio Aiuto <fabioaiuto83@gmail.com>,
Ross Schmidt <ross.schm.dev@gmail.com>,
Marco Cesati <marcocesati@gmail.com>,
Brother Matthew De Angelis <matthew.v.deangelis@gmail.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Ivan Safonov <insafonov@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tablet: acecad: update the reference count of the usb interface structure
Date: Tue, 27 Jul 2021 15:37:56 +0300 [thread overview]
Message-ID: <20210727123756.GL1931@kadam> (raw)
In-Reply-To: <20210724205542.GA549014@pc>
On Sat, Jul 24, 2021 at 09:55:42PM +0100, Salah Triki wrote:
> Use usb_get_intf() and usb_put_intf() in order to update the reference
> count of the usb interface structure.
>
This commit message doesn't say what the user visible effects are. If
you encountered this bug at runtime then please put the stack trace in
the commit mesage.
Add a Fixes tag.
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> ---
> drivers/input/tablet/acecad.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/tablet/acecad.c b/drivers/input/tablet/acecad.c
> index a38d1fe97334..85fe134a30ee 100644
> --- a/drivers/input/tablet/acecad.c
> +++ b/drivers/input/tablet/acecad.c
> @@ -151,7 +151,7 @@ static int usb_acecad_probe(struct usb_interface *intf, const struct usb_device_
> goto fail2;
> }
>
> - acecad->intf = intf;
> + acecad->intf = usb_get_intf(intf);
> acecad->input = input_dev;
>
> if (dev->manufacturer)
You need to call usb_put_intf() if input_register_device() fails.
regards,
dan carpenter
next prev parent reply other threads:[~2021-07-27 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 20:55 [PATCH] tablet: acecad: update the reference count of the usb interface structure Salah Triki
2021-07-27 12:37 ` Dan Carpenter [this message]
2021-07-29 0:54 ` Salah Triki
2021-07-29 8:31 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210727123756.GL1931@kadam \
--to=dan.carpenter@oracle.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=insafonov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcocesati@gmail.com \
--cc=matthew.v.deangelis@gmail.com \
--cc=ross.schm.dev@gmail.com \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).