From: Jason Wang <wangborong@cdjrlc.com>
To: linux@armlinux.org.uk
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Jason Wang <wangborong@cdjrlc.com>
Subject: [PATCH] ARM: scoop: move EXPORT_SYMBOLs to follow their funcs
Date: Tue, 27 Jul 2021 21:05:47 +0800 [thread overview]
Message-ID: <20210727130547.141310-1-wangborong@cdjrlc.com> (raw)
Usually, EXPORT_SYMBOLs should immediately follow their functions or
variables.
Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
arch/arm/common/scoop.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/common/scoop.c b/arch/arm/common/scoop.c
index 6edb961bd6c1..746919c18bb1 100644
--- a/arch/arm/common/scoop.c
+++ b/arch/arm/common/scoop.c
@@ -49,6 +49,7 @@ void reset_scoop(struct device *dev)
iowrite16(0x0000, sdev->base + SCOOP_ISR); /* 1C */
iowrite16(0x0000, sdev->base + SCOOP_IRM);
}
+EXPORT_SYMBOL(reset_scoop);
static void __scoop_gpio_set(struct scoop_dev *sdev,
unsigned offset, int value)
@@ -126,15 +127,13 @@ unsigned short read_scoop_reg(struct device *dev, unsigned short reg)
struct scoop_dev *sdev = dev_get_drvdata(dev);
return ioread16(sdev->base + reg);
}
+EXPORT_SYMBOL(read_scoop_reg);
void write_scoop_reg(struct device *dev, unsigned short reg, unsigned short data)
{
struct scoop_dev *sdev = dev_get_drvdata(dev);
iowrite16(data, sdev->base + reg);
}
-
-EXPORT_SYMBOL(reset_scoop);
-EXPORT_SYMBOL(read_scoop_reg);
EXPORT_SYMBOL(write_scoop_reg);
#ifdef CONFIG_PM
--
2.32.0
next reply other threads:[~2021-07-27 13:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 13:05 Jason Wang [this message]
2021-09-09 14:12 ` [PATCH] ARM: scoop: move EXPORT_SYMBOLs to follow their funcs Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210727130547.141310-1-wangborong@cdjrlc.com \
--to=wangborong@cdjrlc.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).