[PATCH] usb: gadget: f_hid: idle uses the highest byte for duration

[PATCH] usb: gadget: f_hid: idle uses the highest byte for duration

[Maxim Devaev]

SET_IDLE value must be shifted 8 bits to the right to get duration.
This confirmed by USBCV test.

Signed-off-by: Maxim Devaev <mdevaev@gmail.com>
---
 drivers/usb/gadget/function/f_hid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c
index 8d50c8b12..bb476e121 100644
--- a/drivers/usb/gadget/function/f_hid.c
+++ b/drivers/usb/gadget/function/f_hid.c
@@ -573,7 +573,7 @@ static int hidg_setup(struct usb_function *f,
 		  | HID_REQ_SET_IDLE):
 		VDBG(cdev, "set_idle\n");
 		length = 0;
-		hidg->idle = value;
+		hidg->idle = value >> 8;
 		goto respond;
 		break;
 
-- 
2.32.0

Re: [PATCH] usb: gadget: f_hid: idle uses the highest byte for duration

[Greg KH]

On Tue, Jul 27, 2021 at 09:58:00PM +0300, Maxim Devaev wrote:
> SET_IDLE value must be shifted 8 bits to the right to get duration.
> This confirmed by USBCV test.
> 
> Signed-off-by: Maxim Devaev <mdevaev@gmail.com>
> ---
>  drivers/usb/gadget/function/f_hid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c
> index 8d50c8b12..bb476e121 100644
> --- a/drivers/usb/gadget/function/f_hid.c
> +++ b/drivers/usb/gadget/function/f_hid.c
> @@ -573,7 +573,7 @@ static int hidg_setup(struct usb_function *f,
>  		  | HID_REQ_SET_IDLE):
>  		VDBG(cdev, "set_idle\n");
>  		length = 0;
> -		hidg->idle = value;
> +		hidg->idle = value >> 8;
>  		goto respond;
>  		break;
>  
> -- 
> 2.32.0
> 

You forgot to mention what commit this fixes up:

Fixes: afcff6dc690e ("usb: gadget: f_hid: added GET_IDLE and SET_IDLE handlers")

I've added it to the patch now, but try to remember it next time.

thanks,

greg k-h

Re: [PATCH] usb: gadget: f_hid: idle uses the highest byte for duration

[Maxim Devaev]

> Greg KH <gregkh@linuxfoundation.org> wrote:
> You forgot to mention what commit this fixes up:
> 
> Fixes: afcff6dc690e ("usb: gadget: f_hid: added GET_IDLE and SET_IDLE handlers")
> 
> I've added it to the patch now, but try to remember it next time.

This is quite new for me, thank you for suggesting it and for your patience.

Re: [PATCH] usb: gadget: f_hid: idle uses the highest byte for duration

[Felipe Balbi]

Hi,

Maxim Devaev <mdevaev@gmail.com> writes:

> SET_IDLE value must be shifted 8 bits to the right to get duration.
> This confirmed by USBCV test.
>
> Signed-off-by: Maxim Devaev <mdevaev@gmail.com>

with Greg's Fixes addition:

Acked-by: Felipe Balbi <balbi@kernel.org>

-- 
balbi

Re: [PATCH] usb: gadget: f_hid: idle uses the highest byte for duration

[Greg KH]

On Wed, Jul 28, 2021 at 09:31:02AM +0300, Felipe Balbi wrote:
> 
> Hi,
> 
> Maxim Devaev <mdevaev@gmail.com> writes:
> 
> > SET_IDLE value must be shifted 8 bits to the right to get duration.
> > This confirmed by USBCV test.
> >
> > Signed-off-by: Maxim Devaev <mdevaev@gmail.com>
> 
> with Greg's Fixes addition:
> 
> Acked-by: Felipe Balbi <balbi@kernel.org>

Argh, just missed me committing this.  Thanks for the review, sorry it
missed getting added to the final commit :(

greg k-h

Re: [PATCH] usb: gadget: f_hid: idle uses the highest byte for duration

[Felipe Balbi]

Greg KH <gregkh@linuxfoundation.org> writes:
> On Wed, Jul 28, 2021 at 09:31:02AM +0300, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>> Maxim Devaev <mdevaev@gmail.com> writes:
>> 
>> > SET_IDLE value must be shifted 8 bits to the right to get duration.
>> > This confirmed by USBCV test.
>> >
>> > Signed-off-by: Maxim Devaev <mdevaev@gmail.com>
>> 
>> with Greg's Fixes addition:
>> 
>> Acked-by: Felipe Balbi <balbi@kernel.org>
>
> Argh, just missed me committing this.  Thanks for the review, sorry it
> missed getting added to the final commit :(

not a problem, thanks for taking care of all these patches ;-)

-- 
balbi

Re: [PATCH] usb: gadget: f_hid: idle uses the highest byte for duration

[Maxim Devaev]

> Greg KH <gregkh@linuxfoundation.org> wrote:
> Argh, just missed me committing this.  Thanks for the review, sorry it
> missed getting added to the final commit :(

No, it's my fault, I messed up the process and everything went wrong.
I will improve my interaction when working on the next patch.

Sorry again. Although I read the manual on working with kernel mailings,
I forgot about some things. Github PRs and all such things stupefy me :)