From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29679C4338F for ; Tue, 27 Jul 2021 22:54:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F161460EB2 for ; Tue, 27 Jul 2021 22:54:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232620AbhG0WyZ (ORCPT ); Tue, 27 Jul 2021 18:54:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:50114 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232506AbhG0WyX (ORCPT ); Tue, 27 Jul 2021 18:54:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8722860F90; Tue, 27 Jul 2021 22:54:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627426463; bh=FixOnT4n62zd3WCjhcEaUVTcSt68zeKvAj/CsPDOdVM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OwdHcMIazcEPhAYOvmWgnXsgfYMBgos7AHUkMY6nw0KqAHLlpa4CGCBpfupOrN2Vz 6e2eWbC6F8qY5nZR9LoDqlQCIXphIXBStWY1o/YQjErUqA/lhHUwtvDrvblayfIvsd DHDjF7VyhWW/7RQXVZHOWwUGjDF+y+hwQyXZPi4oNE7N8TMAwLnlwq3TETPZPOsG1H IVOukfOkGtJ51IxtHDhH3Xa3NxQJMyjntjvFwwZ7Xa+ZpcDDoHJtvcE9XsjLymiwW2 oNct7Oyhg4dU1JbcXwBfEWknLATXjMRIJtvsQ10hi1yUfxpCfAhrlcbQRZWJS7uJWb t07DxwttTgLrw== Date: Wed, 28 Jul 2021 07:54:21 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Tom Zanussi , Namhyung Kim Subject: Re: [PATCH v2 2/2] tracing: Allow execnames to be passed as args for synthetic events Message-Id: <20210728075421.7274872181a6b92ce5bfa037@kernel.org> In-Reply-To: <20210726092818.7d94027d@oasis.local.home> References: <20210722142705.992001628@goodmis.org> <20210722142837.458596338@goodmis.org> <20210723011935.efb25bc4a23ebd567243ed0f@kernel.org> <20210722123234.636d5363@oasis.local.home> <20210723101133.3378369c618c53f2e71d3e4c@kernel.org> <20210722212438.5933e714@rorschach.local.home> <20210724193145.c63b44aa843e05ed9c0b4fdc@kernel.org> <20210725111830.2f424ae3978443241b6d4a2d@kernel.org> <20210725124502.54fa65251b5cd5b76fdf5f19@kernel.org> <20210726092818.7d94027d@oasis.local.home> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Jul 2021 09:28:18 -0400 Steven Rostedt wrote: > On Sun, 25 Jul 2021 12:45:02 +0900 > Masami Hiramatsu wrote: > > > And with this change, hist trigger can correctly detect a string type in > > the operand in the expression and rejects it. > > > > Thank you, > > > > >From 5280d1efe4415a621cf69a1dc4861ab928b0ff1c Mon Sep 17 00:00:00 2001 > > From: Masami Hiramatsu > > Date: Sun, 25 Jul 2021 12:34:00 +0900 > > Subject: [PATCH] tracing: Reject string operand in the histogram expression > > > > Since the string type can not be the target of the addition / subtraction > > operation, it must be rejected. Without this fix, the string type silently > > converted to digits. > > Masami, can you send this as a normal patch. My scripts do not work > (nor do I plan on having them ever do so) with patches embedded in > threads or non-patch emails. OK, let me resend it. Thanks, -- Masami Hiramatsu