From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB8C5C432BE for ; Wed, 28 Jul 2021 11:50:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA38D60EB2 for ; Wed, 28 Jul 2021 11:50:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236069AbhG1LuM (ORCPT ); Wed, 28 Jul 2021 07:50:12 -0400 Received: from outbound-smtp31.blacknight.com ([81.17.249.62]:52001 "EHLO outbound-smtp31.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234869AbhG1LuK (ORCPT ); Wed, 28 Jul 2021 07:50:10 -0400 Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp31.blacknight.com (Postfix) with ESMTPS id 338B8C0C9B for ; Wed, 28 Jul 2021 12:50:08 +0100 (IST) Received: (qmail 19191 invoked from network); 28 Jul 2021 11:50:08 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.17.255]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 28 Jul 2021 11:50:08 -0000 Date: Wed, 28 Jul 2021 12:50:06 +0100 From: Mel Gorman To: Peter Zijlstra Cc: mika.penttila@gmail.com, linux-kernel@vger.kernel.org, lirongqing@baidu.com, pbonzini@redhat.com, mingo@redhat.com, kvm@vger.kernel.org, Mel Gorman Subject: Re: [PATCH] is_core_idle() is using a wrong variable Message-ID: <20210728115006.GC3809@techsingularity.net> References: <20210722063946.28951-1-mika.penttila@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 28, 2021 at 12:41:03PM +0200, Peter Zijlstra wrote: > On Thu, Jul 22, 2021 at 09:39:46AM +0300, mika.penttila@gmail.com wrote: > > From: Mika Penttilä > > > > is_core_idle() was using a wrong variable in the loop test. Fix it. > > > > Signed-off-by: Mika Penttilä > > Thanks! > > --- > Subject: sched/numa: Fix is_core_idle() > From: Mika Penttilä > Date: Thu, 22 Jul 2021 09:39:46 +0300 > > From: Mika Penttilä > > Use the loop variable instead of the function argument to test the > other SMT siblings for idle. > > Fixes: ff7db0bf24db ("sched/numa: Prefer using an idle CPU as a migration target instead of comparing tasks") > Signed-off-by: Mika Penttilä > Signed-off-by: Peter Zijlstra (Intel) > Link: https://lkml.kernel.org/r/20210722063946.28951-1-mika.penttila@gmail.com Acked-by: Mel Gorman -- Mel Gorman SUSE Labs