From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: pierre-louis.bossart@linux.intel.com,
rander.wang@linux.intel.com, shumingf@realtek.com,
patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: dapm: Revert "use component prefix when checking widget names"
Date: Wed, 28 Jul 2021 17:09:48 +0100 [thread overview]
Message-ID: <20210728160948.GE4670@sirena.org.uk> (raw)
In-Reply-To: <a882a9e0-db05-2f89-abb9-8b308ccb56c8@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
On Thu, Jul 22, 2021 at 10:55:23AM +0100, Richard Fitzgerald wrote:
> I don't mind if someone wants to change the core dapm functions if that
> is generally useful, providing that it also updates all callers of those
> functions to still work.
> Changing the behaviour of core code to fix the Realtek driver without
> updating other callers of those functions is a problem.
The thing here is that nobody would have thought that that any caller
would have been open coding this stuff like the component things were,
it's simply the wrong abstraction level to be implementing something
like this so people wouldn't think of auditing the callers to find uses
which might notice that prefixing suddenly worked.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-07-28 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 12:50 Richard Fitzgerald
2021-07-05 16:50 ` Mark Brown
2021-07-22 9:55 ` Richard Fitzgerald
2021-07-23 15:17 ` Richard Fitzgerald
2021-07-23 15:24 ` Mark Brown
2021-07-28 16:09 ` Mark Brown [this message]
2021-07-28 18:29 ` Richard Fitzgerald
2021-07-28 23:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210728160948.GE4670@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=rf@opensource.cirrus.com \
--cc=shumingf@realtek.com \
--subject='Re: [PATCH] ASoC: dapm: Revert "use component prefix when checking widget names"' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).