linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH 2/2] drivers: iio: light: cm3323: Add device tree support
       [not found] ` <SG2PR02MB38141E2560616F0514CF9A768FEA9@SG2PR02MB3814.apcprd02.prod.outlook.com>
@ 2021-07-28 17:56   ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2021-07-28 17:56 UTC (permalink / raw)
  To: Siddharth Manthan
  Cc: robh+dt, ktsai, lars, devicetree, linux-kernel, linux-iio, nikita

On Wed, 28 Jul 2021 17:52:16 +0530
Siddharth Manthan <siddharth_manthan@outlook.com> wrote:

> Add Device Tree support for Capella cm3323 Ambient Light Sensor
> 
> Signed-off-by: Siddharth Manthan <siddharth_manthan@outlook.com>
It 'should' have worked without the explicit of_device_id table,
via the fallback that I2C has to use the i2c_device_id table.

I'm fine with making it explicit though as that route doesn't
use the vendor ID at all, so we 'might' get a clash.

I'll change the patch title when applying to something like
iio:light:cm3323: Add of_device_id table

Note also drop the drivers bit as we don't normally have that for
IIO devices.

Jonathan

> ---
>  drivers/iio/light/cm3323.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/iio/light/cm3323.c b/drivers/iio/light/cm3323.c
> index 6d1b0ffd1..fd9a8c27d 100644
> --- a/drivers/iio/light/cm3323.c
> +++ b/drivers/iio/light/cm3323.c
> @@ -256,9 +256,16 @@ static const struct i2c_device_id cm3323_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, cm3323_id);
>  
> +static const struct of_device_id cm3323_of_match[] = {
> +	{ .compatible = "capella,cm3323", },
> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, cm3323_of_match);
> +
>  static struct i2c_driver cm3323_driver = {
>  	.driver = {
>  		.name = CM3323_DRV_NAME,
> +		.of_match_table = cm3323_of_match,
>  	},
>  	.probe		= cm3323_probe,
>  	.id_table	= cm3323_id,


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 2/2] drivers: iio: light: cm3323: Add device tree support
  2021-07-28 11:00 [PATCH 1/2] dt-bindings: Add bindings for Capella cm3323 Ambient Light Sensor Siddharth Manthan
@ 2021-07-28 11:00 ` Siddharth Manthan
  0 siblings, 0 replies; 2+ messages in thread
From: Siddharth Manthan @ 2021-07-28 11:00 UTC (permalink / raw)
  To: jic23
  Cc: robh+dt, nikita, linux-iio, linux-kernel, devicetree, ktsai,
	lars, Siddharth Manthan

Add Device Tree support for Capella cm3323 Ambient Light Sensor

Signed-off-by: Siddharth Manthan <siddharth.manthan@gmail.com>
---
 drivers/iio/light/cm3323.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/iio/light/cm3323.c b/drivers/iio/light/cm3323.c
index 6d1b0ffd144b..fd9a8c27de2e 100644
--- a/drivers/iio/light/cm3323.c
+++ b/drivers/iio/light/cm3323.c
@@ -256,9 +256,16 @@ static const struct i2c_device_id cm3323_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, cm3323_id);
 
+static const struct of_device_id cm3323_of_match[] = {
+	{ .compatible = "capella,cm3323", },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, cm3323_of_match);
+
 static struct i2c_driver cm3323_driver = {
 	.driver = {
 		.name = CM3323_DRV_NAME,
+		.of_match_table = cm3323_of_match,
 	},
 	.probe		= cm3323_probe,
 	.id_table	= cm3323_id,
-- 
2.31.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-28 17:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210728122216.22849-1-siddharth_manthan@outlook.com>
     [not found] ` <SG2PR02MB38141E2560616F0514CF9A768FEA9@SG2PR02MB3814.apcprd02.prod.outlook.com>
2021-07-28 17:56   ` [PATCH 2/2] drivers: iio: light: cm3323: Add device tree support Jonathan Cameron
2021-07-28 11:00 [PATCH 1/2] dt-bindings: Add bindings for Capella cm3323 Ambient Light Sensor Siddharth Manthan
2021-07-28 11:00 ` [PATCH 2/2] drivers: iio: light: cm3323: Add device tree support Siddharth Manthan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).