From: Salah Triki <salah.triki@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Fabio Aiuto <fabioaiuto83@gmail.com>,
Ross Schmidt <ross.schm.dev@gmail.com>,
Marco Cesati <marcocesati@gmail.com>,
Brother Matthew De Angelis <matthew.v.deangelis@gmail.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Ivan Safonov <insafonov@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tablet: acecad: update the reference count of the usb interface structure
Date: Thu, 29 Jul 2021 01:54:27 +0100 [thread overview]
Message-ID: <20210729005427.GA784014@pc> (raw)
In-Reply-To: <20210727123756.GL1931@kadam>
On Tue, Jul 27, 2021 at 03:37:56PM +0300, Dan Carpenter wrote:
> This commit message doesn't say what the user visible effects are. If
> you encountered this bug at runtime then please put the stack trace in
> the commit mesage.
>
I made this patch based on the following documentation of
usb_get_intf():
[quote]
Each live reference to a interface must be refcounted.
Drivers for USB interfaces should normally record such references
in their probe methods, when they bind to an interface, and release them
by calling usb_put_intf, in their disconnect methods.
[/quote]
Thanx
next prev parent reply other threads:[~2021-07-29 0:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 20:55 [PATCH] tablet: acecad: update the reference count of the usb interface structure Salah Triki
2021-07-27 12:37 ` Dan Carpenter
2021-07-29 0:54 ` Salah Triki [this message]
2021-07-29 8:31 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210729005427.GA784014@pc \
--to=salah.triki@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=insafonov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcocesati@gmail.com \
--cc=matthew.v.deangelis@gmail.com \
--cc=ross.schm.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).