From: Bart Van Assche <bvanassche@acm.org> To: Christoph Hellwig <hch@lst.de> Cc: Joel Becker <jlbec@evilplan.org>, linux-kernel@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>, Brendan Higgins <brendanhiggins@google.com>, David Gow <davidgow@google.com>, Shuah Khan <skhan@linuxfoundation.org>, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, Bodo Stroesser <bostroesser@gmail.com>, "Martin K . Petersen" <martin.petersen@oracle.com>, Yanko Kaneti <yaneti@declera.com> Subject: [PATCH v2 2/3] kunit: Add support for suite initialization and cleanup Date: Wed, 28 Jul 2021 21:41:24 -0700 [thread overview] Message-ID: <20210729044125.7435-3-bvanassche@acm.org> (raw) In-Reply-To: <20210729044125.7435-1-bvanassche@acm.org> Reviewed-by: Brendan Higgins <brendanhiggins@google.com> Cc: David Gow <davidgow@google.com> Cc: Shuah Khan <skhan@linuxfoundation.org> Cc: kunit-dev@googlegroups.com Cc: linux-kselftest@vger.kernel.org Cc: Bodo Stroesser <bostroesser@gmail.com> Cc: Martin K. Petersen <martin.petersen@oracle.com> Cc: Yanko Kaneti <yaneti@declera.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- include/kunit/test.h | 4 ++++ lib/kunit/test.c | 14 ++++++++++++++ 2 files changed, 18 insertions(+) diff --git a/include/kunit/test.h b/include/kunit/test.h index 24b40e5c160b..a6eef96a409c 100644 --- a/include/kunit/test.h +++ b/include/kunit/test.h @@ -215,6 +215,8 @@ static inline char *kunit_status_to_ok_not_ok(enum kunit_status status) * struct kunit_suite - describes a related collection of &struct kunit_case * * @name: the name of the test. Purely informational. + * @init_suite: called once per test suite before the test cases. + * @exit_suite: called once per test suite after all test cases. * @init: called before every test case. * @exit: called after every test case. * @test_cases: a null terminated array of test cases. @@ -229,6 +231,8 @@ static inline char *kunit_status_to_ok_not_ok(enum kunit_status status) */ struct kunit_suite { const char name[256]; + int (*init_suite)(void); + void (*exit_suite)(void); int (*init)(struct kunit *test); void (*exit)(struct kunit *test); struct kunit_case *test_cases; diff --git a/lib/kunit/test.c b/lib/kunit/test.c index d79ecb86ea57..c271692ced93 100644 --- a/lib/kunit/test.c +++ b/lib/kunit/test.c @@ -397,9 +397,19 @@ int kunit_run_tests(struct kunit_suite *suite) { char param_desc[KUNIT_PARAM_DESC_SIZE]; struct kunit_case *test_case; + int res = 0; kunit_print_subtest_start(suite); + if (suite->init_suite) + res = suite->init_suite(); + + if (res < 0) { + kunit_log(KERN_INFO, suite, KUNIT_SUBTEST_INDENT + "# Suite initialization failed (%d)\n", res); + goto end; + } + kunit_suite_for_each_test_case(suite, test_case) { struct kunit test = { .param_value = NULL, .param_index = 0 }; test_case->status = KUNIT_SKIPPED; @@ -439,6 +449,10 @@ int kunit_run_tests(struct kunit_suite *suite) test.status_comment); } + if (suite->exit_suite) + suite->exit_suite(); + +end: kunit_print_subtest_end(suite); return 0;
next prev parent reply other threads:[~2021-07-29 4:41 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-29 4:41 [PATCH v2 0/3] Restore the kernel v5.13 text attribute write behavior Bart Van Assche 2021-07-29 4:41 ` [PATCH v2 1/3] configfs: " Bart Van Assche 2021-07-29 4:41 ` Bart Van Assche [this message] 2021-07-29 5:55 ` [PATCH v2 2/3] kunit: Add support for suite initialization and cleanup Greg KH 2021-07-29 16:52 ` Bart Van Assche 2021-07-29 16:55 ` Shuah Khan 2021-07-29 17:16 ` Bart Van Assche 2021-07-29 18:42 ` Shuah Khan 2021-07-29 19:22 ` Bart Van Assche 2021-07-29 20:42 ` Shuah Khan 2021-07-29 4:41 ` [PATCH v2 3/3] configfs: Add unit tests Bart Van Assche
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210729044125.7435-3-bvanassche@acm.org \ --to=bvanassche@acm.org \ --cc=bostroesser@gmail.com \ --cc=brendanhiggins@google.com \ --cc=davidgow@google.com \ --cc=hch@lst.de \ --cc=jlbec@evilplan.org \ --cc=kunit-dev@googlegroups.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=skhan@linuxfoundation.org \ --cc=yaneti@declera.com \ --subject='Re: [PATCH v2 2/3] kunit: Add support for suite initialization and cleanup' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).