From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Rui Wang <wangrui@loongson.cn>
Cc: Peter Zijlstra <peterz@infradead.org>,
Will Deacon <will@kernel.org>, Boqun Feng <boqun.feng@gmail.com>,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
hev <r@hev.cc>
Subject: Re: [RFC PATCH] locking/atomic: arch/mips: Fix atomic{_64,}_sub_if_positive
Date: Thu, 29 Jul 2021 11:53:42 +0200 [thread overview]
Message-ID: <20210729095342.GB8286@alpha.franken.de> (raw)
In-Reply-To: <20210729082549.144559-1-wangrui@loongson.cn>
On Thu, Jul 29, 2021 at 04:25:49PM +0800, Rui Wang wrote:
> This looks like a typo and that caused atomic64 test failed.
>
> Signed-off-by: Rui Wang <wangrui@loongson.cn>
> Signed-off-by: hev <r@hev.cc>
> ---
> arch/mips/include/asm/atomic.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/atomic.h b/arch/mips/include/asm/atomic.h
> index 95e1f7f3597f..a0b9e7c1e4fc 100644
> --- a/arch/mips/include/asm/atomic.h
> +++ b/arch/mips/include/asm/atomic.h
> @@ -206,7 +206,7 @@ ATOMIC_OPS(atomic64, xor, s64, ^=, xor, lld, scd)
> * The function returns the old value of @v minus @i.
> */
> #define ATOMIC_SIP_OP(pfx, type, op, ll, sc) \
> -static __inline__ int arch_##pfx##_sub_if_positive(type i, pfx##_t * v) \
> +static __inline__ type arch_##pfx##_sub_if_positive(type i, pfx##_t * v) \
> { \
> type temp, result; \
> \
sub_if_postive looks unused to me. Could you send a patch removing it
instead ? riscv also has a sub_if_positive implementation, which looks
unused.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2021-07-29 9:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 8:25 [RFC PATCH] locking/atomic: arch/mips: Fix atomic{_64,}_sub_if_positive Rui Wang
2021-07-29 9:03 ` Boqun Feng
2021-07-29 9:15 ` hev
2021-07-29 9:53 ` Thomas Bogendoerfer [this message]
2021-07-29 11:00 ` hev
2021-07-29 12:31 ` hev
2021-07-29 14:33 ` Thomas Bogendoerfer
2021-08-04 13:46 ` hev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210729095342.GB8286@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=r@hev.cc \
--cc=wangrui@loongson.cn \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).