From: Miaohe Lin <linmiaohe@huawei.com>
To: <hannes@cmpxchg.org>, <mhocko@kernel.org>,
<vdavydov.dev@gmail.com>, <akpm@linux-foundation.org>
Cc: <shakeelb@google.com>, <guro@fb.com>, <willy@infradead.org>,
<alexs@kernel.org>, <richard.weiyang@gmail.com>,
<songmuchun@bytedance.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <cgroups@vger.kernel.org>,
<linmiaohe@huawei.com>
Subject: [PATCH 5/5] mm, memcg: always call __mod_node_page_state() with preempt disabled
Date: Thu, 29 Jul 2021 20:57:55 +0800 [thread overview]
Message-ID: <20210729125755.16871-6-linmiaohe@huawei.com> (raw)
In-Reply-To: <20210729125755.16871-1-linmiaohe@huawei.com>
We should always ensure __mod_node_page_state() is called with preempt
disabled or percpu ops may manipulate the wrong cpu when preempt happened.
Fixes: b4e0b68fbd9d ("mm: memcontrol: use obj_cgroup APIs to charge kmem pages")
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/memcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 70a32174e7c4..616d1a72ece3 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -697,8 +697,8 @@ void __mod_lruvec_page_state(struct page *page, enum node_stat_item idx,
memcg = page_memcg(head);
/* Untracked pages have no memcg, no lruvec. Update only the node */
if (!memcg) {
- rcu_read_unlock();
__mod_node_page_state(pgdat, idx, val);
+ rcu_read_unlock();
return;
}
--
2.23.0
next prev parent reply other threads:[~2021-07-29 12:58 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 12:57 [PATCH 0/5] Cleanups and fixup for memcontrol Miaohe Lin
2021-07-29 12:57 ` [PATCH 1/5] mm, memcg: remove unused functions Miaohe Lin
2021-07-29 14:07 ` Shakeel Butt
2021-07-30 2:39 ` Muchun Song
2021-07-30 2:57 ` Roman Gushchin
2021-07-30 6:45 ` Michal Hocko
2021-07-29 12:57 ` [PATCH 2/5] mm, memcg: narrow the scope of percpu_charge_mutex Miaohe Lin
2021-07-30 2:42 ` Muchun Song
2021-07-30 3:06 ` Roman Gushchin
2021-07-30 6:50 ` Michal Hocko
2021-07-31 2:29 ` Miaohe Lin
2021-08-02 6:49 ` Michal Hocko
2021-08-02 9:54 ` Miaohe Lin
2021-08-03 3:40 ` Roman Gushchin
2021-08-03 6:29 ` Miaohe Lin
2021-08-03 7:11 ` Michal Hocko
2021-08-03 7:13 ` Roman Gushchin
2021-08-03 7:27 ` Michal Hocko
2021-08-03 9:33 ` Muchun Song
2021-08-03 10:50 ` Miaohe Lin
2021-08-03 14:15 ` Johannes Weiner
2021-08-04 8:20 ` Michal Hocko
2021-08-05 1:44 ` Miaohe Lin
2021-07-30 6:46 ` Michal Hocko
2021-07-29 12:57 ` [PATCH 3/5] mm, memcg: save some atomic ops when flush is already true Miaohe Lin
2021-07-29 14:40 ` Shakeel Butt
2021-07-30 2:37 ` Muchun Song
2021-07-30 3:07 ` Roman Gushchin
2021-07-30 6:51 ` Michal Hocko
2021-07-29 12:57 ` [PATCH 4/5] mm, memcg: avoid possible NULL pointer dereferencing in mem_cgroup_init() Miaohe Lin
2021-07-29 13:52 ` Matthew Wilcox
2021-07-30 1:50 ` Miaohe Lin
2021-07-30 3:12 ` Roman Gushchin
2021-07-30 6:29 ` Miaohe Lin
2021-07-30 6:44 ` Michal Hocko
2021-07-31 2:05 ` Miaohe Lin
2021-08-02 6:43 ` Michal Hocko
2021-08-02 10:00 ` Miaohe Lin
2021-08-02 10:42 ` Michal Hocko
2021-08-02 11:18 ` Miaohe Lin
2021-07-29 12:57 ` Miaohe Lin [this message]
2021-07-29 14:39 ` [PATCH 5/5] mm, memcg: always call __mod_node_page_state() with preempt disabled Shakeel Butt
2021-07-30 1:52 ` Miaohe Lin
2021-07-30 2:33 ` [External] " Muchun Song
2021-07-30 2:46 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210729125755.16871-6-linmiaohe@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=alexs@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=richard.weiyang@gmail.com \
--cc=shakeelb@google.com \
--cc=songmuchun@bytedance.com \
--cc=vdavydov.dev@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).