From: Christian Brauner <christian.brauner@ubuntu.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, hch@lst.de, virtio-fs@redhat.com,
v9fs-developer@lists.sourceforge.net, stefanha@redhat.com,
miklos@szeredi.hu
Subject: Re: [PATCH v3 0/3] support booting of arbitrary non-blockdevice file systems
Date: Thu, 29 Jul 2021 17:08:16 +0200 [thread overview]
Message-ID: <20210729150816.jg5brzgt7nndhtdi@wittgenstein> (raw)
In-Reply-To: <20210714202321.59729-1-vgoyal@redhat.com>
On Wed, Jul 14, 2021 at 04:23:18PM -0400, Vivek Goyal wrote:
> Hi,
>
> This is V3 of patches. Christoph had posted V2 here.
>
> https://lore.kernel.org/linux-fsdevel/20210621062657.3641879-1-hch@lst.de/
>
> There was a small issue in last patch series that list_bdev_fs_names()
> did not put an extra '\0' at the end as current callers were expecting.
>
> To fix this, I have modified list_bdev_fs_names() and split_fs_names()
> to return number of null terminated strings they have parsed. And
> modified callers to use that to loop through strings (instead of
> relying on an extra null at the end).
>
> Christoph was finding it hard to find time so I took his patches,
> added my changes in patch3 and reposting the patch series.
>
> I have tested it with 9p, virtiofs and ext4 filesystems as rootfs
> and it works for me.
lgtm,
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
prev parent reply other threads:[~2021-07-29 15:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 20:23 [PATCH v3 0/3] support booting of arbitrary non-blockdevice file systems Vivek Goyal
2021-07-14 20:23 ` [PATCH v3 1/3] init: split get_fs_names Vivek Goyal
2021-07-15 10:04 ` Stefan Hajnoczi
2021-07-14 20:23 ` [PATCH v3 2/3] init: allow mounting arbitrary non-blockdevice filesystems as root Vivek Goyal
2021-07-15 10:04 ` Stefan Hajnoczi
2021-07-14 20:23 ` [PATCH v3 3/3] fs: simplify get_filesystem_list / get_all_fs_names Vivek Goyal
2021-07-21 15:46 ` Stefan Hajnoczi
2021-07-30 0:57 ` Al Viro
2021-07-30 12:24 ` Vivek Goyal
2021-07-27 18:29 ` [PATCH v3 0/3] support booting of arbitrary non-blockdevice file systems Vivek Goyal
2021-07-29 15:08 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210729150816.jg5brzgt7nndhtdi@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=stefanha@redhat.com \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=vgoyal@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).