From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1FCDC4338F for ; Thu, 29 Jul 2021 22:35:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8DCD60F5E for ; Thu, 29 Jul 2021 22:35:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234589AbhG2WfF (ORCPT ); Thu, 29 Jul 2021 18:35:05 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:49134 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233586AbhG2Wex (ORCPT ); Thu, 29 Jul 2021 18:34:53 -0400 Message-ID: <20210729222542.621609423@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1627598088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: references:references; bh=o7/zZ56Eqe+3Hqo1lY6fvcr08Gf8JGm1/pSYYMhs5e8=; b=g3S9BXQFyt3rvNWuWuEpt2gy02gWaWVRlb74t+2+ElrBtzTb0uqGmOVrR7yzEaHo8iaHWA l+kXpM7YHAhUABKtx6U3lPqMF8aLlSUi8ZXz3rQCuVYVfkNa9fJFCR+d/uC/CpGOxwBPFF 4DzC50Gr5R645FO0kBJu1uEIHUAFJH1plEqjbZ76+viFBKCiXLdDIEkC/JhJGz4QM+yll0 CuI+LKJzFayiDPwiPHwIqw98Qp7Pffc52zdfgcYGjr981wZeWIA6DLPIZSO9u+aWm4x8cM xIayc8CEUSJkUOOA7Ij/Q/Nt3Sr0Pycf0g+bcrLAeqqdIqu8idsK3rAZGbae7Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1627598088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: references:references; bh=o7/zZ56Eqe+3Hqo1lY6fvcr08Gf8JGm1/pSYYMhs5e8=; b=IKVQjOWuih3kib5537AQMYxUhKsPIaQq1rWcg5FTro3uBqzMD0NaOW6oQtQJVaSo6+0+Sf 1MY3Oo8LvlbF7nDw== Date: Thu, 29 Jul 2021 23:51:45 +0200 From: Thomas Gleixner To: LKML Cc: Alex Williamson , "Raj, Ashok" , "David S. Miller" , Bjorn Helgaas , linux-pci@vger.kernel.org, Kevin Tian , Marc Zyngier , Ingo Molnar , x86@kernel.org, linux-s390@vger.kernel.org, Niklas Schnelle , Gerald Schaefer , Heiko Carstens , Christian Borntraeger Subject: [patch V2 06/19] PCI/MSI: Correct misleading comments References: <20210729215139.889204656@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-transfer-encoding: 8-bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The comments about preserving the cached state in pci_msi[x]_shutdown() are misleading as the MSI descriptors are freed right after those functions return. So there is nothing to restore. Signed-off-by: Thomas Gleixner --- V2: New patch --- drivers/pci/msi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -961,7 +961,6 @@ static void pci_msi_shutdown(struct pci_ /* Return the device with MSI unmasked as initial states */ mask = msi_mask(desc->msi_attrib.multi_cap); - /* Keep cached state to be restored */ __pci_msi_desc_mask_irq(desc, mask, 0); /* Restore dev->irq to its default pin-assertion IRQ */ @@ -1047,10 +1046,8 @@ static void pci_msix_shutdown(struct pci } /* Return the device with MSI-X masked as initial states */ - for_each_pci_msi_entry(entry, dev) { - /* Keep cached states to be restored */ + for_each_pci_msi_entry(entry, dev) __pci_msix_desc_mask_irq(entry, 1); - } pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0); pci_intx_for_msi(dev, 1);