From: Herbert Xu <herbert@gondor.apana.org.au>
To: Mian Yousaf Kaukab <ykaukab@suse.de>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
stefanb@linux.ibm.com, davem@davemloft.net, tiwai@suse.de,
guillaume.gardet@arm.com
Subject: Re: [PATCH] crypto: ecc: handle unaligned input buffer in ecc_swap_digits
Date: Fri, 30 Jul 2021 11:11:04 +0800 [thread overview]
Message-ID: <20210730031103.GE12121@gondor.apana.org.au> (raw)
In-Reply-To: <20210721083905.15144-1-ykaukab@suse.de>
On Wed, Jul 21, 2021 at 10:39:05AM +0200, Mian Yousaf Kaukab wrote:
> ecdsa_set_pub_key() makes an u64 pointer at 1 byte offset of the key.
> This results in an unaligned u64 pointer. This pointer is passed to
> ecc_swap_digits() which assumes natural alignment.
>
> This causes a kernel crash on an armv7 platform:
> [ 0.409022] Unhandled fault: alignment exception (0x001) at 0xc2a0a6a9
> ...
> [ 0.416982] PC is at ecdsa_set_pub_key+0xdc/0x120
> ...
> [ 0.491492] Backtrace:
> [ 0.492059] [<c07c266c>] (ecdsa_set_pub_key) from [<c07c75d4>] (test_akcipher_one+0xf4/0x6c0)
>
> Handle unaligned input buffer in ecc_swap_digits() by replacing
> be64_to_cpu() to get_unaligned_be64(). Change type of in pointer to
> void to reflect it doesn’t necessarily need to be aligned.
>
> Fixes: 4e6602916bc6 ("crypto: ecdsa - Add support for ECDSA signature verification")
> Reported-by: Guillaume Gardet <guillaume.gardet@arm.com>
> Suggested-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
> ---
> crypto/ecc.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2021-07-30 3:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 8:39 [PATCH] crypto: ecc: handle unaligned input buffer in ecc_swap_digits Mian Yousaf Kaukab
2021-07-21 12:10 ` Stefan Berger
2021-07-30 3:11 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210730031103.GE12121@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=guillaume.gardet@arm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanb@linux.ibm.com \
--cc=tiwai@suse.de \
--cc=ykaukab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).